Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolve some nits in the codebase #708

Open
wants to merge 12 commits into
base: main
Choose a base branch
from
Open

Resolve some nits in the codebase #708

wants to merge 12 commits into from

Commits on Nov 11, 2024

  1. S5915 Unindent asserts in context blocks

    @DiamondJoseph
    DiamondJoseph committed Nov 11, 2024
    Configuration menu
    Copy the full SHA
    19e5c8f View commit details
    Browse the repository at this point in the history

  2. Remove non-exported ConfigLoader

    @DiamondJoseph
    DiamondJoseph committed Nov 11, 2024
    Configuration menu
    Copy the full SHA
    5ae758a View commit details
    Browse the repository at this point in the history

  3. Import from packages for non __init__ modules

    @DiamondJoseph
    DiamondJoseph committed Nov 11, 2024
    Configuration menu
    Copy the full SHA
    9d82038 View commit details
    Browse the repository at this point in the history

  4. Remove unexported declaration

    @DiamondJoseph
    DiamondJoseph committed Nov 11, 2024
    Configuration menu
    Copy the full SHA
    342ab74 View commit details
    Browse the repository at this point in the history

  5. Annotated fixtures and use builtin tmp_path

    @DiamondJoseph
    DiamondJoseph committed Nov 11, 2024
    Configuration menu
    Copy the full SHA
    dcaa11b View commit details
    Browse the repository at this point in the history

  6. Remove type: ignore where possible

    @DiamondJoseph
    DiamondJoseph committed Nov 11, 2024
    Configuration menu
    Copy the full SHA
    cc3e7c4 View commit details
    Browse the repository at this point in the history

  7. Update Union typing

    @DiamondJoseph
    DiamondJoseph committed Nov 11, 2024
    Configuration menu
    Copy the full SHA
    7cc1d5a View commit details
    Browse the repository at this point in the history

  8. Raise ValidationError correctly.

    @DiamondJoseph
    DiamondJoseph committed Nov 11, 2024
    Configuration menu
    Copy the full SHA
    3aeea90 View commit details
    Browse the repository at this point in the history

  9. noqa where type: ignore insufficient

    @DiamondJoseph
    DiamondJoseph committed Nov 11, 2024
    Configuration menu
    Copy the full SHA
    f4d70ae View commit details
    Browse the repository at this point in the history

Commits on Nov 13, 2024

  1. ruff enforce absolute imports

    @DiamondJoseph
    DiamondJoseph committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    dd9128c View commit details
    Browse the repository at this point in the history

  2. Annotate more mocks and remove unused mocks without side effects

    @DiamondJoseph
    DiamondJoseph committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    90963cc View commit details
    Browse the repository at this point in the history

  3. test commit cast objects to mock when checking

    @DiamondJoseph
    DiamondJoseph committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    7b885bd View commit details
    Browse the repository at this point in the history