Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert Lists to Sets #18

Merged
merged 2 commits into from
Jul 10, 2024
Merged

Convert Lists to Sets #18

merged 2 commits into from
Jul 10, 2024

Conversation

keithralphs
Copy link
Contributor

Change parameters in plans that are actualy Sets but listed as Lists to Sets so that the BlueAPI generated JSONSchema is more accurate.

Copy link

codecov bot commented Jul 10, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 90.17%. Comparing base (04592c4) to head (afaf658).
Report is 2 commits behind head on main.

Files Patch % Lines
src/dls_bluesky_core/plans/wrapped.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #18      +/-   ##
==========================================
- Coverage   91.47%   90.17%   -1.30%     
==========================================
  Files          13       12       -1     
  Lines         129      112      -17     
==========================================
- Hits          118      101      -17     
  Misses         11       11              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@keithralphs keithralphs merged commit bb8d083 into main Jul 10, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants