Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initial commit: update pip3-skeleton with project specifics #4

Merged
merged 3 commits into from
Aug 24, 2023
Merged

Initial commit: update pip3-skeleton with project specifics #4

merged 3 commits into from
Aug 24, 2023

Conversation

DiamondJoseph
Copy link
Contributor

  • Limit python compatibility to those versions supported by BlueAPI

@DiamondJoseph
Copy link
Contributor Author

Tagged @gilesknap for review to make sure I have removed all the correct skeleton things and @keithralphs as he understands the purpose of the repository and can check if my docs make sense.

gilesknap
gilesknap reviewed Aug 24, 2023
View reviewed changes
Copy link
Contributor

@gilesknap gilesknap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. One minor comment.

.github/workflows/code.yml Show resolved Hide resolved
@DiamondJoseph DiamondJoseph merged commit ce24de5 into main Aug 24, 2023
17 checks passed
@DiamondJoseph DiamondJoseph deleted the hello_world branch August 24, 2023 15:21
@DiamondJoseph DiamondJoseph mentioned this pull request Oct 16, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gilesknap gilesknap gilesknap approved these changes

@keithralphs keithralphs Awaiting requested review from keithralphs

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DiamondJoseph @gilesknap