add eiger timeouts availability #806
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stan-dot
added
enhancement
stan-dot
force-pushed
the
256-parameterise-all_frames_timeout-in-eiger
branch
from
6cfa033
to
5422a2a
Compare
stan-dot
force-pushed
the
256-parameterise-all_frames_timeout-in-eiger
branch
from
5422a2a
to
74e712d
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #806 +/- ##
=======================================
Coverage 95.63% 95.64%
=======================================
Files 128 128
Lines 5271 5279 +8
=======================================
+ Hits 5041 5049 +8
Misses 230 230 ☔ View full report in Codecov by Sentry. |
olliesilvester
approved these changes
Nov 12, 2024
src/dodal/devices/eiger.py
Outdated
| if beamline in AVAILABLE_TIMEOUTS: | ||
| self.timeouts = AVAILABLE_TIMEOUTS[beamline] | ||
| else: | ||
| raise ValueError(f"Unknown beamline_name: {beamline}") |
There was a problem hiding this comment.
Could: I think it's better to use i03's timeout values as defaults rather than raising an error here. Then we could log a message to say that default values are being used
There was a problem hiding this comment.
Please could you also add a test for this line
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #256
Instructions to reviewer on how to test:
Checks for reviewer
dodal connect ${BEAMLINE}