Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

863 make ophyd devices for rasor #879

Open
wants to merge 36 commits into
base: main
Choose a base branch
from

Conversation

Relm-Arrowny
Copy link
Contributor

@Relm-Arrowny Relm-Arrowny commented Nov 1, 2024

Fixes #863

Instructions to reviewer on how to test:

  1. Run unit-test
  2. test "dodal connect i10"

Checks for reviewer

  • Would the PR title make sense to a scientist on a set of release notes
  • If a new device has been added does it follow the standards
  • If changing the API for a pre-existing device, ensure that any beamlines using this device have updated their Bluesky plans accordingly
  • Have the connection tests for the relevant beamline(s) been run via dodal connect ${BEAMLINE}

@Relm-Arrowny Relm-Arrowny linked an issue Nov 1, 2024 that may be closed by this pull request
2 tasks
Copy link

codecov bot commented Nov 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.31%. Comparing base (b4c87ae) to head (93dcd3d).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #879      +/-   ##
==========================================
+ Coverage   96.04%   96.31%   +0.27%     
==========================================
  Files         136      145       +9     
  Lines        5639     6059     +420     
==========================================
+ Hits         5416     5836     +420     
  Misses        223      223              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Relm-Arrowny Relm-Arrowny self-assigned this Nov 27, 2024
@Relm-Arrowny Relm-Arrowny marked this pull request as ready for review December 2, 2024 13:58
@Relm-Arrowny Relm-Arrowny requested a review from a team as a code owner December 2, 2024 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make Ophyd devices for Rasor.
1 participant