-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update i20-1 to use device_factory #922
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #922 +/- ##
=======================================
Coverage 96.04% 96.04%
=======================================
Files 136 136
Lines 5633 5636 +3
=======================================
+ Hits 5410 5413 +3
Misses 223 223 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
all connection fails but caget fails also
Appears to be trying to connect to i20? Should NOT be merged until this is resolved. |
ah yes the behavior of |
9e1a549
to
080936c
Compare
Reveals #926 on attempting to connect- |
080936c
to
7134287
Compare
Instructions to reviewer on how to test:
Checks for reviewer
dodal connect ${BEAMLINE}