Add schema-stable and schema-nightly argoCD apps #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iamvigneshwars
force-pushed
the
schema-app
branch
from
3749e9c
to
8040f9a
Compare
garryod
requested changes
Jul 2, 2024
iamvigneshwars
force-pushed
the
schema-app
branch
from
514deba
to
dc8c045
Compare
iamvigneshwars
force-pushed
the
schema-app
branch
3 times, most recently
from
e720605
to
f358bb4
Compare
iamvigneshwars
force-pushed
the
schema-app
branch
from
f358bb4
to
0689c7d
Compare
garryod
requested changes
Jul 3, 2024
There was a problem hiding this comment.
Looking good, I like the move to a proper GitOps style with the schema versioning, do you think we should extend that to the graph deployment too?
Also, what changes are needed to load the schema into the router? And can we get rid of the managed federation stuff?
garryod
reviewed
Jul 3, 2024
iamvigneshwars
force-pushed
the
schema-app
branch
5 times, most recently
from
95c460e
to
87c9668
Compare
…c for stable release
iamvigneshwars
force-pushed
the
schema-app
branch
from
87c9668
to
38b64ba
Compare
garryod
approved these changes
Jul 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #22