Helm chart for Apollo router #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iamvigneshwars
force-pushed
the
apollo-router
branch
from
55d7437
to
b2824f6
Compare
iamvigneshwars
force-pushed
the
apollo-router
branch
from
b2824f6
to
2ca939a
Compare
garryod
requested changes
Mar 18, 2024
iamvigneshwars
force-pushed
the
apollo-router
branch
from
98fb92c
to
8c75518
Compare
garryod
requested changes
Mar 18, 2024
charts/data-gateway/values.yaml
Outdated
Comment on lines
227
to
253
| configuration: | ||
| supergraph: | ||
| listen: 0.0.0.0:4000 | ||
| health_check: | ||
| listen: 0.0.0.0:8088 | ||
| telemetry: | ||
| instrumentation: | ||
| spans: | ||
| mode: spec_compliant | ||
| exporters: | ||
| metrics: | ||
| common: | ||
| resource: | ||
| "service.name": "router" | ||
| otlp: | ||
| enabled: true | ||
| endpoint: '{{ .Release.Name }}-opentelemetry-collector:4317' | ||
| protocol: grpc | ||
| tracing: | ||
| common: | ||
| resource: | ||
| "service.name": "router" | ||
| otlp: | ||
| enabled: true | ||
| endpoint: '{{ .Release.Name }}-opentelemetry-collector:4317' | ||
| protocol: grpc |
There was a problem hiding this comment.
Suggested change
| configuration: | |
| supergraph: | |
| listen: 0.0.0.0:4000 | |
| health_check: | |
| listen: 0.0.0.0:8088 | |
| telemetry: | |
| instrumentation: | |
| spans: | |
| mode: spec_compliant | |
| exporters: | |
| metrics: | |
| common: | |
| resource: | |
| "service.name": "router" | |
| otlp: | |
| enabled: true | |
| endpoint: '{{ .Release.Name }}-opentelemetry-collector:4317' | |
| protocol: grpc | |
| tracing: | |
| common: | |
| resource: | |
| "service.name": "router" | |
| otlp: | |
| enabled: true | |
| endpoint: '{{ .Release.Name }}-opentelemetry-collector:4317' | |
| protocol: grpc | |
| configuration: {} | |
| myConfiguration: | |
| supergraph: | |
| listen: 0.0.0.0:4000 | |
| health_check: | |
| listen: 0.0.0.0:8088 | |
| telemetry: | |
| instrumentation: | |
| spans: | |
| mode: spec_compliant | |
| exporters: | |
| metrics: | |
| common: | |
| resource: | |
| "service.name": "router" | |
| otlp: | |
| enabled: true | |
| endpoint: '{{ .Release.Name }}-opentelemetry-collector:4317' | |
| protocol: grpc | |
| tracing: | |
| common: | |
| resource: | |
| "service.name": "router" | |
| otlp: | |
| enabled: true | |
| endpoint: '{{ .Release.Name }}-opentelemetry-collector:4317' | |
| protocol: grpc |
iamvigneshwars
force-pushed
the
apollo-router
branch
from
8c75518
to
8371bc1
Compare
garryod
approved these changes
Mar 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds apollo router deployment.
Ingress: data-gateway.diamond.ac.uk