Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix secret collision #36

Merged
merged 2 commits into from
Sep 17, 2024
Merged

Fix secret collision #36

merged 2 commits into from
Sep 17, 2024

Conversation

garryod
Copy link
Member

@garryod garryod commented Jul 18, 2024 •
edited
Loading

Prefixes the oauth2 client secret name with the helm .Release.Name to avoid name collision between the stable and nightly instance. Blocked by templating of extraVolumes in the oauth2-proxy helm chart - PR to add

@garryod garryod added bug Something isn't working helm Helm chart labels Jul 18, 2024
@garryod garryod self-assigned this Jul 18, 2024
@garryod garryod force-pushed the fix-secret-collision branch 3 times, most recently from 1326e69 to bba15e1 Compare September 17, 2024 12:38
@garryod garryod marked this pull request as ready for review September 17, 2024 12:38
iamvigneshwars
iamvigneshwars approved these changes Sep 17, 2024
View reviewed changes
Copy link
Contributor

@iamvigneshwars iamvigneshwars left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@garryod garryod merged commit 9989135 into main Sep 17, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iamvigneshwars iamvigneshwars iamvigneshwars approved these changes

Assignees

@garryod garryod

Labels
bug Something isn't working helm Helm chart
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@garryod @iamvigneshwars