Move default aperture position to constants

src/mx_bluesky/hyperion/parameters/constants.py

@@ -1,6 +1,7 @@
 import os
 from enum import Enum
 
+from dodal.devices.aperturescatterguard import AperturePositionGDANames
 from dodal.devices.detector import EIGER2_X_16M_SIZE
 from pydantic.dataclasses import dataclass
 
@@ -77,6 +78,11 @@ class GridscanParamConstants:
  OMEGA_2 = 90.0
 
 
+@dataclass(frozen=True)
+class RotationParamConstants:
+ DEFAULT_APERTURE_POSITION = AperturePositionGDANames.LARGE_APERTURE
+
+
 @dataclass(frozen=True)
 class DetectorParamConstants:
  BEAM_XY_LUT_PATH = (
@@ -90,6 +96,7 @@ class DetectorParamConstants:
 class ExperimentParamConstants:
  DETECTOR = DetectorParamConstants()
  GRIDSCAN = GridscanParamConstants()
+ ROTATION = RotationParamConstants()
 
 
 _test_oav_file = "tests/test_data/test_OAVCentring.json"

src/mx_bluesky/hyperion/parameters/rotation.py

@@ -33,9 +33,11 @@
  TemporaryIspybExtras,
  WithScan,
 )
-from mx_bluesky.hyperion.parameters.constants import CONST, I03Constants
-
-DEFAULT_APERTURE_POSITION = AperturePositionGDANames.LARGE_APERTURE
+from mx_bluesky.hyperion.parameters.constants import (
+ CONST,
+ I03Constants,
+ RotationParamConstants,
+)
 
 
 class RotationScanPerSweep(OptionalGonioAngleStarts, OptionalXyzStarts):
@@ -89,9 +91,9 @@ def _set_default_aperture_position(
  ):
  if not aperture_position:
  LOGGER.warning(
- f"No aperture position selected. Defaulting to {DEFAULT_APERTURE_POSITION}"
+ f"No aperture position selected. Defaulting to {RotationParamConstants.DEFAULT_APERTURE_POSITION}"
  )
- return DEFAULT_APERTURE_POSITION
+ return RotationParamConstants.DEFAULT_APERTURE_POSITION
  else:
  return aperture_position