Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rename I24 to i24 #142

Merged
merged 3 commits into from
Aug 7, 2024
Merged

rename I24 to i24 #142

merged 3 commits into from
Aug 7, 2024

Conversation

dperl-dls
Copy link
Contributor

@dperl-dls dperl-dls commented Aug 7, 2024 •
edited
Loading

fixes #143

Also needs DiamondLightSource/dodal#731

for consistency with beamline modules elsewhere (e.g. in dodal) and python conventions generally

to test:

  • check references to "I24" in python modules or corresponding directories have been updated
  • run tests

olliesilvester
olliesilvester approved these changes Aug 7, 2024
View reviewed changes
Copy link
Contributor

@olliesilvester olliesilvester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests pass and there are no more mx_bluesky.I24 's

@dperl-dls dperl-dls merged commit 5fc1927 into main Aug 7, 2024
13 checks passed
@dperl-dls dperl-dls deleted the standardise_capitalisation branch August 7, 2024 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olliesilvester olliesilvester olliesilvester approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

standardise capitalisation
2 participants
@dperl-dls @olliesilvester