I24 ssx: determine detector #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #17 +/- ##
==========================================
+ Coverage 28.98% 29.19% +0.21%
==========================================
Files 16 16
Lines 3940 3956 +16
==========================================
+ Hits 1142 1155 +13
- Misses 2798 2801 +3
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
DominicOram
requested changes
Jun 6, 2023
There was a problem hiding this comment.
Thanks, few suggestions:
- Can you add the changes where you're using these functions into this PR too?
- Can we return the detector class rather than a string? If we need the string put it as a param on the class
- Given 2 can we add a return type to
get_detector_type
Comment on lines
+49
to
+50
| det_y_threshold = 200.0 | ||
| det_y_target = 220.0 |
There was a problem hiding this comment.
Nice place to store these!
|
Made the suggested changes, merging now because needed in #16 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a small function to find which detector is in use.
Employing roughly the same logic used in GDA to check the detector and move it to correct positioning. There's probably a better way, but for now it does the job.
Part of #14