Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorganise I24 ssx parameters #18

Closed
wants to merge 27 commits into from
Closed

Reorganise I24 ssx parameters #18

wants to merge 27 commits into from

Conversation

noemifrisina
Copy link
Contributor

@noemifrisina noemifrisina commented Jun 8, 2023

Try to set up some sort of parameter model

Part of #14

@codecov
Copy link

codecov bot commented Jun 8, 2023

Codecov Report

Merging #18 (f86c292) into main (6bcd7ba) will decrease coverage by 0.09%.
The diff coverage is 64.43%.

@@            Coverage Diff             @@
##             main      #18      +/-   ##
==========================================
- Coverage   46.41%   46.32%   -0.09%     
==========================================
  Files          19       22       +3     
  Lines        3223     3391     +168     
==========================================
+ Hits         1496     1571      +75     
- Misses       1727     1820      +93     
Files Changed Coverage Δ
src/mx_bluesky/I24/serial/write_nexus.py 19.64% <28.57%> (+5.35%) ⬆️
src/mx_bluesky/I24/serial/initialise_parameters.py 36.00% <36.00%> (ø)
...4/serial/fixed_target/i24ssx_Chip_Collect_py3v1.py 37.43% <37.09%> (-0.83%) ⬇️
...4/serial/extruder/i24ssx_Extruder_Collect_py3v2.py 57.63% <70.17%> (-14.84%) ⬇️
...sky/I24/serial/parameters/experiment_parameters.py 94.82% <94.82%> (ø)
src/mx_bluesky/I24/serial/dcid.py 26.85% <100.00%> (-1.24%) ⬇️
src/mx_bluesky/I24/serial/parameters/__init__.py 100.00% <100.00%> (ø)
src/mx_bluesky/I24/serial/parameters/constants.py 100.00% <100.00%> (ø)
...c/mx_bluesky/I24/serial/setup_beamline/__init__.py 100.00% <100.00%> (ø)
...x_bluesky/I24/serial/setup_beamline/pv_abstract.py 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant