Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused chips #24

Merged
merged 23 commits into from
Jul 12, 2023
Merged

Remove unused chips #24

merged 23 commits into from
Jul 12, 2023

Conversation

noemifrisina
Copy link
Contributor

Closes #20

  • Remove chips from code
  • Remove chips from dropdown menu in edm
  • Tidy up numbers and make sure they match

@codecov
Copy link

codecov bot commented Jul 10, 2023

Codecov Report

Merging #24 (3c85861) into main (9d762c5) will increase coverage by 1.83%.
The diff coverage is 35.41%.

@@            Coverage Diff             @@
##             main      #24      +/-   ##
==========================================
+ Coverage   40.05%   41.88%   +1.83%     
==========================================
  Files          18       18              
  Lines        3468     3335     -133     
==========================================
+ Hits         1389     1397       +8     
+ Misses       2079     1938     -141     
Impacted Files Coverage Δ
...4/serial/fixed_target/i24ssx_Chip_Mapping_py3v1.py 12.59% <0.00%> (ø)
...esky/I24/serial/fixed_target/i24ssx_moveonclick.py 11.11% <0.00%> (ø)
src/mx_bluesky/I24/serial/write_nexus.py 14.28% <0.00%> (-0.61%) ⬇️
...4/serial/fixed_target/i24ssx_Chip_Manager_py3v1.py 13.59% <27.77%> (+4.08%) ⬆️
...4/serial/fixed_target/i24ssx_Chip_Collect_py3v1.py 36.40% <35.71%> (+2.02%) ⬆️
...4/serial/fixed_target/i24ssx_Chip_StartUp_py3v1.py 38.09% <60.00%> (+0.87%) ⬆️
src/mx_bluesky/I24/serial/parameters/constants.py 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@noemifrisina noemifrisina marked this pull request as ready for review July 12, 2023 09:12
@noemifrisina noemifrisina merged commit a37063a into main Jul 12, 2023
16 of 17 checks passed
@noemifrisina noemifrisina deleted the 20_remove-unused-chips branch July 12, 2023 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

I24 ssx tidy up: remove unused chips from code
2 participants