Configure shutter to always use the manual/auto option #446
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olliesilvester
requested changes
Sep 4, 2024
| @@ -273,6 +275,13 @@ def run_gridscan( | |||
| LOGGER.info("Waiting for gridscan validity check") | |||
| yield from wait_for_gridscan_valid(feature_controlled.fgs_motors) | |||
|
|
|||
| LOGGER.info("Set shutter to auto") | |||
| yield from bps.abs_set( | |||
There was a problem hiding this comment.
Could: Set shutter to auto (or check that it's in auto mode) during the individual setup_zebra plans. It's potentially misleading for plans like setup_zebra_for_gridscan to call set_shutter_auto_input while it's actually still in manual. Another option is for set_shutter_auto_input to include this check
| LOGGER.info("Tidying up Zebra") | ||
| yield from set_zebra_shutter_to_manual(fgs_composite.zebra, group=group, wait=wait) | ||
| LOGGER.info("Tidying up Zebra and shutter") | ||
| yield from tidy_up_zebra_after_gridscan(fgs_composite.zebra, group=group, wait=wait) |
There was a problem hiding this comment.
Similar to my last comment, I think the tidy up plan itself should include setting the shutter to manual, otherwise the tidy_up_zebra_after_gridscan plan is a bit misleading
olliesilvester
approved these changes
Sep 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #232
Requires DiamondLightSource/dodal#770
To test: