Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use pmac abort program #466

Merged
merged 4 commits into from
Sep 13, 2024
Merged

Use pmac abort program #466

merged 4 commits into from
Sep 13, 2024

Conversation

noemifrisina
Copy link
Contributor

Uses change in Dodal#771

DominicOram
DominicOram requested changes Sep 12, 2024
View reviewed changes
Copy link
Contributor

@DominicOram DominicOram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great thanks. One comment.

Should: We should change the test_run_aborted_plan to assert the abort signal is triggered as although this will still work it's testing implementation details of the device

DominicOram
DominicOram approved these changes Sep 13, 2024
View reviewed changes
Copy link
Contributor

@DominicOram DominicOram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thank you!

@DominicOram DominicOram merged commit ea7b4e8 into main Sep 13, 2024
16 checks passed
@DominicOram DominicOram deleted the dodal_771-pmac-wait-for-status branch September 13, 2024 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DominicOram DominicOram DominicOram approved these changes

@dperl-dls dperl-dls Awaiting requested review from dperl-dls

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@noemifrisina @DominicOram