Wait between taking snapshots on robot load #474
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not using the trigger(wait=True) due to bluesky/bluesky#1795
dperl-dls
approved these changes
Sep 12, 2024
| @@ -124,7 +124,7 @@ def take_robot_snapshots(oav: OAV, webcam: Webcam, directory: Path): | |||
| ) | |||
| yield from bps.abs_set(device.directory, str(directory)) | |||
| yield from bps.trigger(device, group="snapshots") | |||
| yield from bps.wait("snapshots") | |||
| yield from bps.wait("snapshots") | |||
There was a problem hiding this comment.
Would be good to add a comment linking to bluesky/bluesky#1795
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #459
Note we're not using the trigger(wait=True) due to bluesky/bluesky#1795
Also confirm that all other problems in the linked issue are covered by other issues.