Do not reload sample if its already been loaded #480
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DominicOram
changed the title
rtuck99
reviewed
Sep 13, 2024
| def robot_load_then_centre_plan( | ||
| composite: RobotLoadThenCentreComposite, | ||
| params: RobotLoadThenCentre, | ||
| ): | ||
| yield from prepare_for_robot_load(composite) | ||
| # TODO: get these from one source of truth #1347 |
There was a problem hiding this comment.
This is now mx-bluesky issue 254
rtuck99
reviewed
Sep 13, 2024
| @@ -245,8 +257,17 @@ def robot_load_and_snapshots(): | |||
|
|
|||
| yield from bps.wait("reset-lower_gonio") | |||
|
|
|||
| yield from robot_load_and_snapshots() | |||
|
|
|||
| if not ( | |||
There was a problem hiding this comment.
Perhaps we should consider moving robot_load_and_snapshots() out of the function similar to prepare_for_robot_load() - it's quite long I think it's affecting readbility.
rtuck99
reviewed
Sep 13, 2024
| @@ -185,11 +187,21 @@ def raise_exception_if_moved_out_of_cryojet(exception): | |||
| ) | |||
|
|
|||
|
|
|||
| def pin_already_loaded( | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #240
Requires DiamondLightSource/dodal#785
To test: