Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set transmission and turn off xbpm feedback for rotations #481

Merged
merged 3 commits into from
Sep 13, 2024
Merged

Set transmission and turn off xbpm feedback for rotations #481

merged 3 commits into from
Sep 13, 2024

Conversation

DominicOram
Copy link
Contributor

Fixes #205

To test:

  • Confirm tests still pass
  • Confirm new test passes

rtuck99
rtuck99 reviewed Sep 13, 2024
View reviewed changes
tests/unit_tests/hyperion/experiment_plans/test_rotation_scan_plan.py Outdated
and msg.kwargs["group"] == CONST.WAIT.ROTATION_READY_FOR_DC,
)


def test_rotation_scan_triggers_xbpm_then_pauses_xbpm_and_sets_tranmission(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

transmission

rtuck99
rtuck99 approved these changes Sep 13, 2024
View reviewed changes
Copy link
Contributor

@rtuck99 rtuck99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small typo other than that looks fine

@DominicOram DominicOram changed the title Set tranmission and turn off xbpm feedback for rotations Set transmission and turn off xbpm feedback for rotations Sep 13, 2024
@DominicOram DominicOram merged commit 470361a into main Sep 13, 2024
16 checks passed
@DominicOram DominicOram deleted the 205_use_transmission_and_feedback_wrapper branch September 13, 2024 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rtuck99 rtuck99 rtuck99 approved these changes

@dperl-dls dperl-dls Awaiting requested review from dperl-dls

@olliesilvester olliesilvester Awaiting requested review from olliesilvester

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use transmission_and_xbpm_feedback_for_collection_wrapper for rotation scans
2 participants
@DominicOram @rtuck99