Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split robot load into it's own plan #491

Merged
merged 7 commits into from
Sep 30, 2024
Merged

Split robot load into it's own plan #491

merged 7 commits into from
Sep 30, 2024

Conversation

DominicOram
Copy link
Contributor

@DominicOram DominicOram commented Sep 15, 2024

Fixes #490 and fixes #302

To test:

  • Confirm tests still pass and cover the same code without any logical changes

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we please rename this so that it's test_robot_load_then_centre instead of test_wait_for...?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not massively keen on the RobotLoadAndEnergyChange name, I keep wanting to find a robot_load_and_energy_change plan but there isn't one. I think if it's an important aspect of the plan, the plan ought to include the name, otherwise the plan and the parameter / composite names ought to line up.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right. Ideally they should be separate but it's hard to do that whilst we can't do parallel plans. I will make them consistent in saying they do energy changes.

Copy link
Contributor

@rtuck99 rtuck99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from naming comment, all looks good

Copy link

codecov bot commented Sep 24, 2024

Codecov Report

Attention: Patch coverage is 97.67442% with 3 lines in your changes missing coverage. Please review.

Project coverage is 78.01%. Comparing base (f050458) to head (6ab10ed).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #491      +/-   ##
==========================================
+ Coverage   77.90%   78.01%   +0.11%     
==========================================
  Files          89       91       +2     
  Lines        6711     6754      +43     
==========================================
+ Hits         5228     5269      +41     
- Misses       1483     1485       +2     
Components Coverage Δ
i24 SSX 57.12% <ø> (ø)
hyperion 96.24% <97.67%> (-0.02%) ⬇️
other 94.79% <ø> (ø)

@DominicOram DominicOram merged commit 7b9efa7 into main Sep 30, 2024
21 checks passed
@DominicOram DominicOram deleted the 490_split_robot_load branch September 30, 2024 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Split robot load and centring Pass visit in to Hyperion directly
2 participants