Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increase panda pulse width #498

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Increase panda pulse width #498

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions src/mx_bluesky/hyperion/device_setup_plans/setup_panda.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@
MM_TO_ENCODER_COUNTS = 200000
GENERAL_TIMEOUT = 60
TICKS_PER_MS = 1000 # Panda sequencer prescaler will be set to us
PULSE_WIDTH_US = 50


class Enabled(Enum):
Expand Down Expand Up @@ -78,8 +79,6 @@ def _get_seq_table(

delay_between_pulses = time_between_steps_ms * TICKS_PER_MS

PULSE_WIDTH_US = 1

assert delay_between_pulses > PULSE_WIDTH_US

# BITA_1 trigger wired from TTLIN1, this is the trigger input
Expand Down
3 changes: 1 addition & 2 deletions tests/unit_tests/hyperion/device_setup_plans/test_setup_panda.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@

from mx_bluesky.hyperion.device_setup_plans.setup_panda import (
MM_TO_ENCODER_COUNTS,
PULSE_WIDTH_US,
disarm_panda_for_gridscan,
set_panda_directory,
setup_panda_for_flyscan,
Expand Down Expand Up @@ -139,8 +140,6 @@ def test_setup_panda_correctly_configures_table(
][0]

table = table_msg.args[0]

PULSE_WIDTH_US = 1
SPACE_WIDTH_US = int(time_between_x_steps_ms * 1000 - PULSE_WIDTH_US)
expected_seq_rows: list[SeqRow] = [
SeqRow(1, SeqTrigger.BITA_1, 0, 0, 0, 1, 0),
Expand Down