Add sleep to gridscan validity check #503
Conversation
| @@ -349,6 +349,7 @@ def wait_for_gridscan_valid(fgs_motors: FastGridScanCommon, timeout=0.5): | |||
| LOGGER.info("Waiting for valid fgs_params") | |||
| SLEEP_PER_CHECK = 0.1 | |||
| times_to_check = int(timeout / SLEEP_PER_CHECK) | |||
| yield from bps.sleep(0.1) | |||
There was a problem hiding this comment.
Should: I think I would like to be certain this is the issue before we introduce new sleeps. Can you test it out on the hardware? If this is the issue we should probably spend a bit of time thinking about a cleaner way of handling it, maybe by pushing it into the device more
There was a problem hiding this comment.
Yeah, I can try and test this on a Tuesday, I guess by forcing Hyperion to go from valid to invalid params every time. The scan invalid PV is added to the archiver too now, which should help
This reverts commit 6b5f1a7.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #503 +/- ##
===========================================
+ Coverage 57.08% 77.61% +20.53%
===========================================
Files 28 89 +61
Lines 3199 6705 +3506
===========================================
+ Hits 1826 5204 +3378
- Misses 1373 1501 +128 ☔ View full report in Codecov by Sentry. |
|
Pretty sure this is caused by https://jira.diamond.ac.uk/browse/I03-993. so no need for the sleep |
Fixes #502 (maybe...)
Other option is to wait for PV to be archived and wait to see the error again