-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add checker pattern to pump probe for I24 serial #66
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #66 +/- ##
==========================================
+ Coverage 48.23% 48.94% +0.70%
==========================================
Files 22 22
Lines 3344 3355 +11
==========================================
+ Hits 1613 1642 +29
+ Misses 1731 1713 -18 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine but if we're adding in this new functonality we might as well make it an ophyd device?
Well, the only thing it does is a caput to the pmac string if set to True in the MUX, so it should probably use this Dodal#254 once it's done. For now I mostly wanted to add this new bit so it's available on the beamline |
Yes, it's small, which means that it's a really easy, small ophyd device. It seems like we might as well add this in ophyd now. Otherwise we'll end up adding more functionality in the old way of doing it whilst also trying to move to the new way of doing it, seems like wasted effort? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems fine
Closes #65
Adds new setting to to the pump probe options, which sends a command to the pmac to only have the pump_repeat applied every other city block.