Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add checker pattern to pump probe for I24 serial #66

Merged
merged 6 commits into from
Dec 7, 2023

Conversation

noemifrisina
Copy link
Contributor

Closes #65

Adds new setting to to the pump probe options, which sends a command to the pmac to only have the pump_repeat applied every other city block.

@noemifrisina noemifrisina added the I24 serial Issues relating to ssx on I24 label Dec 1, 2023
Copy link

codecov bot commented Dec 1, 2023

Codecov Report

Attention: 16 lines in your changes are missing coverage. Please review.

Comparison is base (648f8f7) 48.23% compared to head (281552b) 48.94%.

Files Patch % Lines
...4/serial/fixed_target/i24ssx_Chip_Manager_py3v1.py 0.00% 14 Missing ⚠️
...4/serial/fixed_target/i24ssx_Chip_Collect_py3v1.py 81.81% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #66      +/-   ##
==========================================
+ Coverage   48.23%   48.94%   +0.70%     
==========================================
  Files          22       22              
  Lines        3344     3355      +11     
==========================================
+ Hits         1613     1642      +29     
+ Misses       1731     1713      -18     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@DominicOram DominicOram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine but if we're adding in this new functonality we might as well make it an ophyd device?

@noemifrisina
Copy link
Contributor Author

Well, the only thing it does is a caput to the pmac string if set to True in the MUX, so it should probably use this Dodal#254 once it's done. For now I mostly wanted to add this new bit so it's available on the beamline

@DominicOram
Copy link
Contributor

Yes, it's small, which means that it's a really easy, small ophyd device. It seems like we might as well add this in ophyd now. Otherwise we'll end up adding more functionality in the old way of doing it whilst also trying to move to the new way of doing it, seems like wasted effort?

Copy link
Contributor

@dperl-dls dperl-dls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine

@dperl-dls dperl-dls dismissed DominicOram’s stale review December 6, 2023 17:30

Requested changes were made

@noemifrisina noemifrisina merged commit 678858b into main Dec 7, 2023
15 of 16 checks passed
@noemifrisina noemifrisina deleted the 65_add-checker-pattern branch December 7, 2023 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
I24 serial Issues relating to ssx on I24
Projects
None yet
Development

Successfully merging this pull request may close these issues.

I24ssx: Add Checker Pattern
3 participants