Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix devIocStats by including posix headers #134

Merged
merged 1 commit into from
Jun 8, 2023

Conversation

AlexanderWells-diamond
Copy link
Collaborator

This relies on the config_var "POSIX" being defined as True/False for the current platform.

The test is pretty simple, just the CPU count and IOC CPU load as they're fairly easy to calculate

Fixes #131

@github-actions
Copy link

github-actions bot commented Jun 7, 2023

Unit Test Results

     15 files  ±  0       15 suites  ±0   29m 33s ⏱️ +58s
   273 tests +  1     257 ✔️ +  1    16 💤 ±0  0 ±0 
4 095 runs  +15  3 505 ✔️ +15  590 💤 ±0  0 ±0 

Results for commit 40dfcfa. ± Comparison against base commit 289897e.

♻️ This comment has been updated with latest results.

@codecov
Copy link

codecov bot commented Jun 7, 2023

Codecov Report

Merging #134 (40dfcfa) into master (289897e) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #134   +/-   ##
=======================================
  Coverage   87.44%   87.44%           
=======================================
  Files          14       14           
  Lines         996      996           
=======================================
  Hits          871      871           
  Misses        125      125           

Copy link
Contributor

@coretl coretl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for doing this

This relies on the config_var "POSIX" being defined as True/False for
the current platform.

The test is pretty simple, just the CPU count and IOC CPU load as
they're fairly easy to calculate
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

devIocStats: SYS_CPU_LOAD and IOC_CPU_LOAD values are incorrect
2 participants