Add get_field and set_field methods to records #140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexanderWells-diamond
force-pushed
the
get_and_set_fields
branch
from
8014c2f
to
0dca326
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #140 +/- ##
==========================================
+ Coverage 87.56% 87.73% +0.17%
==========================================
Files 14 14
Lines 1005 1019 +14
==========================================
+ Hits 880 894 +14
Misses 125 125 ☔ View full report in Codecov by Sentry. |
AlexanderWells-diamond
force-pushed
the
get_and_set_fields
branch
2 times, most recently
from
36f7f66
to
9c56552
Compare
These allow access to all EPICS attributes on a record. Also add documentation and tests
AlexanderWells-diamond
force-pushed
the
get_and_set_fields
branch
from
9c56552
to
a9fa7f7
Compare
AlexanderWells-diamond
requested review from
Araneidae
and removed request for
Araneidae
Araneidae
approved these changes
Nov 27, 2023
| If you need to set a field's value before that, set it directly as an attribute | ||
| on the record e.g. ``my_record.EGU``. (This will not work after the IOC is | ||
| initialized) | ||
|
|
There was a problem hiding this comment.
It's a shame that the same documentation has to be repeated verbatim here, but as discussed, the fix involves quite a big rework of this document. If anything, this is a job for another time.
AlexanderWells-diamond
force-pushed
the
get_and_set_fields
branch
from
8775a88
to
eb4febb
Compare
This is required due to a side-effect of making the /stable endpoint also redirect to the GHPages version of the docs - the objects.inv link does not correctly survive the redirect.
AlexanderWells-diamond
force-pushed
the
get_and_set_fields
branch
from
eb4febb
to
906e058
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These allow access to all EPICS attributes on a record.
Also add documentation and tests
Closes #139