Fix recursive set bug #141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes a potential deadlock between the GIL and EPICS record lock
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #141 +/- ##
=======================================
Coverage 87.73% 87.73%
=======================================
Files 14 14
Lines 1019 1019
=======================================
Hits 894 894
Misses 125 125 ☔ View full report in Codecov by Sentry. |
Note that this test is most recreatable with cothread==2.19.1, but that version doesn't support Python3.6, which pythonSoftIOC still declares support for. So just leave it unpinned and assume users will likely get that version!
AlexanderWells-diamond
force-pushed
the
fix_recursive_set_bug
branch
from
569596a
to
43bb3dd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prevent a deadlock by ensuring the GIL is released when attempting to acquire EPICS record locks.
Closes #119