Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow waveform.set() to be called before iocInit() #22

Merged
merged 3 commits into from
Aug 10, 2021

Conversation

MJGaughran
Copy link
Contributor

Fixes #21.

With CGP-182 (944e072), waveform.set() was modified to use the dtype attribute, which is only created after softioc.iocInit() is called.

This change adds a default for dtype, preventing this issue.

@Araneidae
Copy link
Collaborator

@thomascobb , didn't realise our CI was so broken! I asked @MJGaughran to make this a pull request so that CI would give it a sanity check ... but that seems to be a bit busted 😞

@Araneidae
Copy link
Collaborator

Am happy with this, but will wait for CI to be fixed I guess...

@AlexanderWells-diamond
Copy link
Collaborator

PR #20 contains both documentation fixes and fixes for the CI. Once that's merged this should clear up. It's also pending review at the moment.

@thomascobb
Copy link
Contributor

I'll make a couple of docs tweaks to #20 then merge it

With CGP-182 (944e072), waveform.set() was modified to use the dtype
attribute, which is only created after softioc.iocInit() is called.

This change adds a default for dtype, preventing this issue.
@codecov
Copy link

codecov bot commented Aug 10, 2021

Codecov Report

Merging #22 (3dda72c) into master (ee1ba0c) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #22      +/-   ##
==========================================
+ Coverage   82.03%   82.05%   +0.02%     
==========================================
  Files          13       13              
  Lines         796      797       +1     
==========================================
+ Hits          653      654       +1     
  Misses        143      143              
Impacted Files Coverage Δ
softioc/device.py 74.74% <100.00%> (+0.13%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ee1ba0c...3dda72c. Read the comment docs.

@thomascobb thomascobb merged commit 3356f44 into master Aug 10, 2021
@thomascobb
Copy link
Contributor

I added a test too and merged in master

@thomascobb thomascobb deleted the fix-waveform-set branch August 10, 2021 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to run waveform.set() before softioc.iocInit()
5 participants