Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Package sdist properly #86

Merged
merged 4 commits into from
Mar 4, 2022
Merged

Package sdist properly #86

merged 4 commits into from
Mar 4, 2022

Conversation

thomascobb
Copy link
Contributor

Fixes #83

@codecov
Copy link

codecov bot commented Feb 22, 2022

Codecov Report

Merging #86 (10192bb) into master (b0d2ef7) will decrease coverage by 0.10%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #86      +/-   ##
==========================================
- Coverage   87.70%   87.59%   -0.11%     
==========================================
  Files          13       13              
  Lines         927      927              
==========================================
- Hits          813      812       -1     
- Misses        114      115       +1     
Impacted Files Coverage Δ
softioc/__main__.py 0.00% <0.00%> (-5.89%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b0d2ef7...10192bb. Read the comment docs.

@github-actions
Copy link

github-actions bot commented Feb 22, 2022

Unit Test Results

     15 files  ±0       15 suites  ±0   20m 42s ⏱️ + 1m 53s
   224 tests ±0     218 ✔️ ±0      6 💤 ±0  0 ±0 
3 360 runs  ±0  2 925 ✔️ ±0  435 💤 ±0  0 ±0 

Results for commit 10192bb. ± Comparison against base commit b0d2ef7.

♻️ This comment has been updated with latest results.

@thomascobb thomascobb force-pushed the sdist-fix branch 8 times, most recently from b2d4b5d to f6bc079 Compare February 23, 2022 16:12
@AlexanderWells-diamond
Copy link
Collaborator

Are you thinking of keeping the -X faulthandler with pytest's -s flag? Does it give readable results in case of a failure?

@thomascobb
Copy link
Contributor Author

Are you thinking of keeping the -X faulthandler with pytest's -s flag? Does it give readable results in case of a failure?

Yes, it is enabled just for windows, which doesn't add any extra output. It hasn't failed yet, so no idea if it gives more readable results, we'll have to wait and see!

@thomascobb thomascobb marked this pull request as ready for review March 4, 2022 14:38
Copy link
Collaborator

@AlexanderWells-diamond AlexanderWells-diamond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@thomascobb thomascobb merged commit 242cdff into master Mar 4, 2022
@thomascobb thomascobb deleted the sdist-fix branch March 4, 2022 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sdist not packaged properly for windows
3 participants