Check AsyncioDispatcher loop is running #96
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also added documentation. Also fixed potential permanent block in tests - if the subprocess never creates its Client, the parent process blocks forever on an accept(). This was the case in the asyncio_ioc_override, where initialization was failing due to non-running loop.
Codecov Report
@@ Coverage Diff @@
## master #96 +/- ##
==========================================
+ Coverage 87.60% 87.63% +0.02%
==========================================
Files 13 13
Lines 928 930 +2
==========================================
+ Hits 813 815 +2
Misses 115 115
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also added documentation.
Also fixed potential permanent block in tests - if the subprocess never creates its Client, the parent process blocks forever on an accept().
This was the case in the asyncio_ioc_override, where initialization was failing due to non-running loop.
Closes #95.