add tests for the case where files already exist #109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
assert on contents of the "latest" file
wermajew
added a commit
that referenced
this pull request
Jul 9, 2024
* remove unused imports * print md5 when local matches remote * use S3's etag to store the md5 instead of a user defined meta entry. This is because we can only know the md5 *after* the upload has completed, and we must set meta at the time of the upload, so we were using the original file's md5 instead of the transferred file md5 * improve logging messages * reject file if md5 doesn't match (and noCheckMd5 option is not enabled) * remove unused variable and import * add some downloader tests * name file properly * remove unecessary code * inline variable only used once * reduce jacoco coverage target for the downloader module * fix: add assertions for 'latest' obj * add tests for the case where files already exist assert on contents of the "latest" file * Revert "fix: add assertions for 'latest' obj" This reverts commit cb14328. * add tests for the case where files already exist (#109) assert on contents of the "latest" file * tests for LocalFileAcceptor --------- Co-authored-by: Weronika Majewska <wmajewska@endeavorstreaming.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
assert on contents of the "latest" file