Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/unquote etag header #110

Merged
merged 3 commits into from
Jul 12, 2024
Merged

Fix/unquote etag header #110

merged 3 commits into from
Jul 12, 2024

Conversation

gedl
Copy link
Contributor

@gedl gedl commented Jul 11, 2024

No description provided.

lcardito
lcardito previously approved these changes Jul 11, 2024
Copy link
Member

@brunocorreiaweb brunocorreiaweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unit tests would help here in the future 🙏

@gedl gedl dismissed stale reviews from brunocorreiaweb and lcardito via 1f59f71 July 11, 2024 10:30
Copy link

codecov bot commented Jul 11, 2024

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 58.75%. Comparing base (7e098d6) to head (1f59f71).

Files Patch % Lines
...here/downloader/destination/s3/S3FileAcceptor.java 0.00% 2 Missing ⚠️
...technology/dice/dicewhere/downloader/Download.java 0.00% 1 Missing ⚠️
.../dice/dicewhere/downloader/source/s3/S3Source.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master     #110      +/-   ##
============================================
- Coverage     58.78%   58.75%   -0.04%     
  Complexity      370      370              
============================================
  Files            97       97              
  Lines          1912     1913       +1     
  Branches        167      167              
============================================
  Hits           1124     1124              
- Misses          729      730       +1     
  Partials         59       59              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lcardito lcardito merged commit 6703b9d into master Jul 12, 2024
1 of 3 checks passed
@lcardito lcardito deleted the fix/unquote_etag_header branch July 12, 2024 09:45
lcardito added a commit that referenced this pull request Jul 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants