Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace per-node measure functions with a single measure function + per-node context #490

Merged
merged 27 commits into from
Oct 9, 2023
Merged

Replace per-node measure functions with a single measure function + per-node context #490

merged 27 commits into from
Oct 9, 2023

Commits on Oct 9, 2023

  1. Add Context to Measurable trait

    @nicoburns
    nicoburns committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    1bd6839 View commit details
    Browse the repository at this point in the history

  2. Add context type parameter to Taffy struct

    @nicoburns
    nicoburns committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    09d8f2e View commit details
    Browse the repository at this point in the history

  3. Remove Send+Sync bound from Measurable and create separate SyncMeasur… 

    …eFunc type
    @nicoburns
    nicoburns committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    169f31f View commit details
    Browse the repository at this point in the history

  4. Fix clippy lints

    @nicoburns
    nicoburns committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    8d5b177 View commit details
    Browse the repository at this point in the history

  5. Make Taffy constructors generic again

    @nicoburns
    nicoburns committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    ab7c459 View commit details
    Browse the repository at this point in the history

  6. Merge RawWithContext MeasureFunc variant into Raw variant

    @nicoburns
    nicoburns committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    8ddd3b9 View commit details
    Browse the repository at this point in the history

  7. Fix typo 

    Co-authored-by: TimJentzsch <TimJentzsch.github.com@timjen.net>
    @alice-i-cecile @TimJentzsch @nicoburns
    2 people authored and nicoburns committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    0305f07 View commit details
    Browse the repository at this point in the history

  8. Fix typo 

    Co-authored-by: TimJentzsch <TimJentzsch.github.com@timjen.net>
    @alice-i-cecile @TimJentzsch @nicoburns
    2 people authored and nicoburns committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    e078c4c View commit details
    Browse the repository at this point in the history

  9. Make Measurable::measure take &mut self

    @nicoburns
    nicoburns committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    ef0b196 View commit details
    Browse the repository at this point in the history

  10. Convert compute code to work with mutable measurables

    @nicoburns
    nicoburns committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    b1c320e View commit details
    Browse the repository at this point in the history

  11. Update docs + add constructor to MeasureFunc

    @nicoburns
    nicoburns committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    9799fd4 View commit details
    Browse the repository at this point in the history

  12. Convert gentests to use custom Measurable

    @nicoburns
    nicoburns committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    8883810 View commit details
    Browse the repository at this point in the history

  13. Implement TaffyView

    @nicoburns
    nicoburns committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    532d09a View commit details
    Browse the repository at this point in the history

  14. Standardise on &mut context

    @nicoburns
    nicoburns committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    1109829 View commit details
    Browse the repository at this point in the history

  15. Fix clippy lints

    @nicoburns
    nicoburns committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    6f27f2f View commit details
    Browse the repository at this point in the history

  16. Fixup gap_column_gap_start_index test

    @nicoburns
    nicoburns committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    9fdff66 View commit details
    Browse the repository at this point in the history

  17. Replace per-node measure functions with a single measure function and… 

    … per-node context
    @nicoburns
    nicoburns committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    ccd0167 View commit details
    Browse the repository at this point in the history

  18. Fix print_tree function when taffy_tree feature is not enabled

    @nicoburns
    nicoburns committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    bd5c4fa View commit details
    Browse the repository at this point in the history

  19. Fix print_tree function

    @nicoburns
    nicoburns committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    292f757 View commit details
    Browse the repository at this point in the history

  20. Fix formatting and clippy lints

    @nicoburns
    nicoburns committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    7e115ca View commit details
    Browse the repository at this point in the history

  21. Feature gate print_tree method on std feature

    @nicoburns
    nicoburns committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    58aaec8 View commit details
    Browse the repository at this point in the history

  22. Fix doc references

    @nicoburns
    nicoburns committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    fd78533 View commit details
    Browse the repository at this point in the history

  23. Remove measure_func module

    @nicoburns
    nicoburns committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    79fd2de View commit details
    Browse the repository at this point in the history

  24. Add example of using measure to integrate leaf layout

    @nicoburns
    nicoburns committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    640b1e4 View commit details
    Browse the repository at this point in the history

  25. Re-forbid unsafe code

    @nicoburns
    nicoburns committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    6330be5 View commit details
    Browse the repository at this point in the history

  26. Regenerate tests after rebase

    @nicoburns
    nicoburns committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    dde4431 View commit details
    Browse the repository at this point in the history

  27. Update release notes for measure function changes

    @nicoburns
    nicoburns committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    41c04c7 View commit details
    Browse the repository at this point in the history