Minor: added docs & test-case for updated 'Taffy::remove()' behaviour #512
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mxsdev
approved these changes
Jul 17, 2023
alice-i-cecile
approved these changes
Jul 17, 2023
|
I'll give this a day or two and then merge it: the docstring would be nice but not essential. |
|
@mxsdev if you want to add something - feel free to add (as PR into this branch, or even simply - with comment, what exatly you wish to add, and I add it) - you the author, I'm just a "cleaner" (who is interested in making the code clear). But I dont know your intends & not so good in making docs 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Why did you make this PR?
I apologize for not having time to make this changes to the last PR (#511), but I think, it will be great to add small descriptive-comment for newly added few lines of code and test-case from related issue (#510) - for anyone, who will read sources, not github issues history :)