Prepare for 0.3.13 release #525
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicoburns
force-pushed
the
release/0.3.13
branch
4 times, most recently
from
0081509
to
2b739ca
Compare
TimJentzsch
approved these changes
Aug 14, 2023
|
I agree fully with @TimJentzsch here. |
|
The final linked PR is merged now: just needs backporting right? |
nicoburns
force-pushed
the
release/0.3.13
branch
3 times, most recently
from
54c74eb
to
a6366a8
Compare
* Fixed clippy lint errors (needless_pass_by_ref_mut) * Fixed clippy lint errors (unnecessary_mut_passed) (cherry picked from commit 8974878)
nicoburns
force-pushed
the
release/0.3.13
branch
2 times, most recently
from
cbce3d3
to
434ed37
Compare
* Switch font used in generated tests to Ahem This aligns our gentests with the Web Platform Test suite which also uses Ahem. See https://github.com/Kozea/Ahem * Set gentest font color to green (cherry picked from commit 9a29acd)
(cherry picked from commit 25ffaee)
…em's intrinsic main size (+misc fixes) (#522) * Add tests for bevyengine/bevy#9350 * Pass accurate cross-axis available space when computing a flexbox item's intrinsic main size * Subtract child margin not parent margin when computing stretch-alignment known size * Add extra debug logs to flexbox algorithm * Apply margins to leaf nodes when computing available space for measure functions (cherry picked from commit dab541d)
(cherry picked from commit c9e45e5)
nicoburns
force-pushed
the
release/0.3.13
branch
4 times, most recently
from
ec75d6f
to
b60d588
Compare
…ilable space when it is the root node (#491) * Add viewport control to gentest setup * Add tests for max-width and available space on a CSS Grid root node * Only treat definite available grid space as indefinite when container size is indefinite, and only do so for the final two track sizing steps. (cherry picked from commit 9958624)
* Fix divide by zero when using grid_auto_rows/grid_auto_columns with zero "negative implicit" tracks * Fix over-allocation in the CellOccupancyMatrix when auto-placing in grids that contain negative implicit tracks. * Fix axis conflation when grid_auto_flow is column * Fix computation of auto track offset when initializing negative implicit tracks * Add basic tests for grid_auto_rows and grid_auto_columns
nicoburns
force-pushed
the
release/0.3.13
branch
from
b60d588
to
da10a58
Compare
|
Right, let's include #497 then. If there's pushback from users then plan is:
I've backported that last PR, and also found a couple more PRs to include. FWIW, most of these had small conflicts that needed to be resolved (and/or applied cleanly but then caused test failures), so hopefully we won't need to do too many backports to the 0.3.x branch! |
|
Converting back to a draft as Squash Merge is the only option, and I don't think this one ought to be squashed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Prepare for 0.3.13 release
Context
Backports the following PRs from the
mainbranch:griddependency to0.10#473Feedback wanted
Does it seem reasonable to release #497 in a patch release? It could technically break (change) people's layouts if they currently have
borderorpaddingset on a leaf node. However, it would be quite odd if anybody did have this set as it would currently be having no effect. Nevertheless, we could release this in a minor version update instead.