Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run benchmarks on PRs #543

Closed
wants to merge 2 commits into from
Closed

Run benchmarks on PRs #543

wants to merge 2 commits into from

Conversation

nicoburns
Copy link
Collaborator

Objective

This should allow us to more easily evaluate the performance impact of PRs.

@nicoburns nicoburns added build system Make continuous integration do the tedious things benchmarks Measuring performance labels Oct 1, 2023
@nicoburns nicoburns closed this Oct 1, 2023
@alice-i-cecile
Copy link
Collaborator

FYI, the task runners are not very stable: I haven't had good luck trying this on other projects in the past.

@nicoburns
Copy link
Collaborator Author

FYI, the task runners are not very stable: I haven't had good luck trying this on other projects in the past.

I figured that given that it runs the previous commit on the same runner then it might be good enough to be usable. But I abandoned the idea because it didn't run out of the box, and I didn't really want to spend time on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
benchmarks Measuring performance build system Make continuous integration do the tedious things
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nicoburns @alice-i-cecile