Implement legacy text alignment #698
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicoburns
added
enhancement
nicoburns
force-pushed
the
legacy-text-align
branch
5 times, most recently
from
e0f044b
to
4daf68e
Compare
nicoburns
force-pushed
the
legacy-text-align
branch
from
4daf68e
to
c031782
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
This change applies to Block layout. It is used to implement the "legacy" alignment behaviour of the
<center>element and thealignattribute (e.g.<div align="right">). Regular values oftext-aligndo not affect block layout (only inline layout), but special prefixed values like-webkit-center,-moz-center, etc do. I have named these asLegacyCenter, etc in this PR.Context
This behaviour is actually being standardised even though it's a bit of a hack w3c/csswg-drafts#10388