Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for Delivery on Demand (Mytime) #74

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

MartijnDB
Copy link

Using the 2.1 version of the labeling service, Delivery on Demand (Mytime) is now possible. This adds the necessary fields for that

Copy link
Collaborator

@ameenross ameenross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you also add EAN and ProductURL fields to Content.php? That way we'll have a complete Labelling service 2.1 implementation

@@ -148,6 +148,16 @@ class Shipment extends BaseType
*/
protected $ReturnReference = null;

/**
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use spaces, not tabs.

/**
* @var string
*/
protected $DeliveryTimeStampStart = null;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Timestamp, not TimeStamp

@MartijnDB
Copy link
Author

I've made the changes and added EAN and productUrl.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants