-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow for Delivery on Demand (Mytime) #74
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you also add EAN and ProductURL fields to Content.php? That way we'll have a complete Labelling service 2.1 implementation
src/ComplexTypes/Shipment.php
Outdated
@@ -148,6 +148,16 @@ class Shipment extends BaseType | |||
*/ | |||
protected $ReturnReference = null; | |||
|
|||
/** |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use spaces, not tabs.
src/ComplexTypes/Shipment.php
Outdated
/** | ||
* @var string | ||
*/ | ||
protected $DeliveryTimeStampStart = null; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Timestamp, not TimeStamp
I've made the changes and added EAN and productUrl. |
Using the 2.1 version of the labeling service, Delivery on Demand (Mytime) is now possible. This adds the necessary fields for that