NEW constants EMAIL #31979
Open
NEW constants EMAIL #31979
+16
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NEW __MYCOMPANY_TVAINTRA__ NEW __AMOUNT_MULTICURRENCY_FORMATED__ NEW function dol_set_value($selector, $value) NEW rounding MTL
NEW __MYCOMPANY_TVAINTRA__ NEW __AMOUNT_MULTICURRENCY_FORMATED__ NEW function dol_set_value($selector, $value) NEW rounding MTL
eldy
reviewed
Nov 19, 2024
htdocs/core/lib/functions.lib.php
Outdated
| @@ -6822,6 +6823,8 @@ function price($amount, $form = 0, $outlangs = '', $trunc = 1, $rounding = -1, $ | |||
| $nbdecimal = getDolGlobalInt('MAIN_MAX_DECIMALS_UNIT'); | |||
| } elseif ($forcerounding === 'MT') { | |||
| $nbdecimal = getDolGlobalInt('MAIN_MAX_DECIMALS_TOT'); | |||
| } elseif ($forcerounding === 'MTL') { | |||
| $nbdecimal = getDolGlobalInt('MAIN_MAX_DECIMALS_TOT_LINE'); // TODO Future feature to improve accuracy | |||
There was a problem hiding this comment.
Total of lines are used in accountancy to calculate the total of document. For legal reason, total of lines must match total on document.
For this reason the accuracy of total of lines must always be the same than the accuracy of total of documents, so nb of decimals for total of lines must use MAIN_MAX_DECIMALS_TOT, otherwise, accountancy will always be wrong and total of lines will never match amount in document.
There was a problem hiding this comment.
I understand, so is there a way to improve the precision perhaps by increasing the decimals of the unit prices to 10 or 12?
eldy
added
the
Discussion
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NEW MYCOMPANY_TVAINTRA
NEW AMOUNT_MULTICURRENCY_FORMATED
NEW function dol_set_value($selector, $value)
NEW rounding MTL