-
-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Mapper/Reader/Writer of a Collection #10
Merged
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
4234c31
Add support for Mapper/Reader/Writer of a Collection
tedynaidenov 688610b
Refactor JSONRegistrartionProcessor, add some more unit tests
tedynaidenov cb03240
Replace Type with TypeToken
tedynaidenov a455a96
Remove unused method in JSONRegistrationProcessor
tedynaidenov f1f8c58
Merge branch 'master' of https://github.com/DominoKit/gwt-jackson-apt
tedynaidenov File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
71 changes: 71 additions & 0 deletions
71
...r/src/main/java/org/dominokit/jacksonapt/processor/AbstractCollectionMapperGenerator.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,71 @@ | ||
package org.dominokit.jacksonapt.processor; | ||
|
||
import static org.dominokit.jacksonapt.processor.AbstractMapperProcessor.elementUtils; | ||
import static org.dominokit.jacksonapt.processor.AbstractMapperProcessor.typeUtils; | ||
import static org.dominokit.jacksonapt.processor.ObjectMapperProcessor.DEFAULT_WILDCARD; | ||
|
||
import java.util.List; | ||
|
||
import javax.lang.model.element.Element; | ||
import javax.lang.model.element.Modifier; | ||
import javax.lang.model.element.Name; | ||
import javax.lang.model.type.DeclaredType; | ||
import javax.lang.model.type.TypeMirror; | ||
|
||
import org.dominokit.jacksonapt.JsonDeserializer; | ||
import org.dominokit.jacksonapt.JsonSerializer; | ||
import org.dominokit.jacksonapt.processor.deserialization.FieldDeserializersChainBuilder; | ||
import org.dominokit.jacksonapt.processor.serialization.FieldSerializerChainBuilder; | ||
|
||
import com.squareup.javapoet.ClassName; | ||
import com.squareup.javapoet.CodeBlock; | ||
import com.squareup.javapoet.MethodSpec; | ||
import com.squareup.javapoet.ParameterizedTypeName; | ||
|
||
|
||
public abstract class AbstractCollectionMapperGenerator extends AbstractMapperGenerator { | ||
protected MethodSpec makeNewDeserializerMethod(Element element, Name beanName) { | ||
return MethodSpec.methodBuilder("newDeserializer") | ||
.addModifiers(Modifier.PROTECTED) | ||
.addAnnotation(Override.class) | ||
.returns(ParameterizedTypeName.get(ClassName.get(JsonDeserializer.class), | ||
ClassName.get(getElementType(element)))) | ||
.addStatement("return $L", new FieldDeserializersChainBuilder(getElementType(element)).getInstance(getElementType(element))) | ||
.build(); | ||
} | ||
|
||
protected MethodSpec makeNewSerializerMethod(Element element, Name beanName) { | ||
return MethodSpec.methodBuilder("newSerializer") | ||
.addModifiers(Modifier.PROTECTED) | ||
.addAnnotation(Override.class) | ||
.returns(ParameterizedTypeName.get(ClassName.get(JsonSerializer.class), DEFAULT_WILDCARD)) | ||
.addStatement("return $L", new FieldSerializerChainBuilder(getElementType(element)).getInstance(getElementType(element))) | ||
.build(); | ||
} | ||
|
||
|
||
@Override | ||
protected void generateJsonMappers(TypeMirror beanType, String packageName, Name beanName) { | ||
List<? extends TypeMirror> typeArguments = ((DeclaredType)beanType).getTypeArguments(); | ||
for (TypeMirror typeParamType:typeArguments){ | ||
if(Type.isCollection(typeParamType) || Type.isMap(typeParamType)) | ||
generateJsonMappers(typeParamType, packageName, typeUtils.asElement(typeParamType).getSimpleName()); | ||
else if (Type.isBasicType(typeParamType)) | ||
//In case of basic type, no need to generate serializer | ||
return; | ||
else { | ||
Element typeParamElement = typeUtils.asElement(typeParamType); | ||
String typeParamPackageName = elementUtils.getPackageOf(typeParamElement).getQualifiedName().toString(); | ||
|
||
generateDeserializer(typeParamType, typeParamPackageName, typeParamElement.getSimpleName()); | ||
generateSerializer(typeParamType, typeParamPackageName, typeParamElement.getSimpleName()); | ||
} | ||
} | ||
} | ||
|
||
protected void generateSerializer(TypeMirror beanType, String packageName, Name beanName) { | ||
} | ||
|
||
protected void generateDeserializer(TypeMirror beanType, String packageName, Name beanName) { | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
121 changes: 121 additions & 0 deletions
121
...t-processor/src/main/java/org/dominokit/jacksonapt/processor/AbstractMapperGenerator.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,121 @@ | ||
package org.dominokit.jacksonapt.processor; | ||
|
||
import static org.dominokit.jacksonapt.processor.AbstractMapperProcessor.elementUtils; | ||
import static org.dominokit.jacksonapt.processor.AbstractMapperProcessor.filer; | ||
import static org.dominokit.jacksonapt.processor.AbstractMapperProcessor.typeUtils; | ||
|
||
import java.io.IOException; | ||
|
||
import javax.lang.model.element.Element; | ||
import javax.lang.model.element.Modifier; | ||
import javax.lang.model.element.Name; | ||
import javax.lang.model.element.TypeElement; | ||
import javax.lang.model.type.TypeMirror; | ||
|
||
import org.dominokit.jacksonapt.ObjectMapper; | ||
import org.dominokit.jacksonapt.ObjectReader; | ||
import org.dominokit.jacksonapt.ObjectWriter; | ||
|
||
import com.google.auto.common.MoreTypes; | ||
import com.squareup.javapoet.ClassName; | ||
import com.squareup.javapoet.CodeBlock; | ||
import com.squareup.javapoet.FieldSpec; | ||
import com.squareup.javapoet.JavaFile; | ||
import com.squareup.javapoet.MethodSpec; | ||
import com.squareup.javapoet.ParameterizedTypeName; | ||
import com.squareup.javapoet.TypeName; | ||
import com.squareup.javapoet.TypeSpec; | ||
|
||
public abstract class AbstractMapperGenerator implements MapperGenerator { | ||
|
||
@Override | ||
public void generate(Element element) throws IOException { | ||
String className = enclosingName(element, "_") + (useInterface(element) ? element.getSimpleName() : "Mapper") + "Impl"; | ||
String packageName = elementUtils.getPackageOf(element).getQualifiedName().toString(); | ||
TypeMirror beanType = getElementType(element); | ||
Name beanName = typeUtils.asElement(beanType).getSimpleName(); | ||
|
||
generateJsonMappers(beanType, packageName, beanName); | ||
|
||
TypeSpec.Builder builder = TypeSpec.classBuilder(className) | ||
.addModifiers(Modifier.PUBLIC, Modifier.FINAL) | ||
.superclass(abstractObjectMapper(element)) | ||
.addField(FieldSpec.builder(ClassName.bestGuess(className), "INSTANCE") | ||
.addModifiers(Modifier.PUBLIC, Modifier.STATIC, Modifier.FINAL) | ||
.initializer(CodeBlock.builder().add("new $T()", ClassName.bestGuess(className)).build()). | ||
build()) | ||
.addMethod(makeConstructor(beanName)) | ||
.addMethods(getMapperMethods(element, beanName)); | ||
if (useInterface(element)) | ||
builder.addSuperinterface(TypeName.get(element.asType())); | ||
|
||
TypeSpec classSpec = builder | ||
.build(); | ||
|
||
JavaFile.builder(packageName, classSpec).build().writeTo(filer); | ||
} | ||
|
||
protected static TypeMirror getElementType(Element element) { | ||
if(useInterface(element)){ | ||
TypeMirror objectReader = ((TypeElement) typeUtils.asElement(element.asType())).getInterfaces().get(0); | ||
return MoreTypes.asDeclared(objectReader).getTypeArguments().get(0); | ||
}else{ | ||
return element.asType(); | ||
} | ||
|
||
} | ||
|
||
protected static boolean useInterface(Element element) { | ||
return | ||
Type.isAssignableFrom(element.asType(), ObjectMapper.class) | ||
|| Type.isAssignableFrom(element.asType(), ObjectReader.class) | ||
|| Type.isAssignableFrom(element.asType(), ObjectWriter.class); | ||
} | ||
|
||
protected String enclosingName(Element element, String postfix) { | ||
if (useInterface(element)) { | ||
return element.getEnclosingElement().getSimpleName().toString() + postfix; | ||
|
||
} | ||
return element.getSimpleName().toString() + postfix; | ||
|
||
} | ||
|
||
protected TypeName abstractObjectMapper(Element element) { | ||
TypeMirror beanType = getElementType(element); | ||
return ParameterizedTypeName.get(ClassName.get(getSuperClass()), | ||
ClassName.get(beanType)); | ||
} | ||
|
||
protected MethodSpec makeConstructor(Name beanName) { | ||
return MethodSpec.constructorBuilder() | ||
.addModifiers(Modifier.PUBLIC) | ||
.addStatement("super(\"" + beanName + "\")").build(); | ||
} | ||
|
||
/** | ||
* <p>getSuperClass.</p> | ||
* | ||
* @return a {@link java.lang.Class} object. | ||
*/ | ||
protected abstract Class<?> getSuperClass(); | ||
|
||
/** | ||
* <p>getMapperMethods.</p> | ||
* | ||
* @param element a {@link javax.lang.model.element.Element} object. | ||
* @param beanName a {@link javax.lang.model.element.Name} object. | ||
* @return a {@link java.lang.Iterable} object. | ||
*/ | ||
protected abstract Iterable<MethodSpec> getMapperMethods(Element element, Name beanName); | ||
|
||
/** | ||
* <p>generateJsonMappers.</p> | ||
* | ||
* @param beanType a {@link javax.lang.model.type.TypeMirror} object. | ||
* @param packageName a {@link java.lang.String} object. | ||
* @param beanName a {@link javax.lang.model.element.Name} object. | ||
*/ | ||
protected abstract void generateJsonMappers(TypeMirror beanType, String packageName, Name beanName); | ||
|
||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
35 changes: 35 additions & 0 deletions
35
...processor/src/main/java/org/dominokit/jacksonapt/processor/CollectionMapperGenerator.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,35 @@ | ||
package org.dominokit.jacksonapt.processor; | ||
|
||
import java.util.stream.Collectors; | ||
import java.util.stream.Stream; | ||
|
||
import javax.lang.model.element.Element; | ||
import javax.lang.model.element.Name; | ||
import javax.lang.model.type.TypeMirror; | ||
|
||
import org.dominokit.jacksonapt.AbstractObjectMapper; | ||
|
||
import com.squareup.javapoet.MethodSpec; | ||
|
||
public class CollectionMapperGenerator extends AbstractCollectionMapperGenerator { | ||
@Override | ||
protected Class<?> getSuperClass() { | ||
return AbstractObjectMapper.class; | ||
} | ||
|
||
@Override | ||
protected Iterable<MethodSpec> getMapperMethods(Element element, Name beanName) { | ||
return Stream.of(makeNewDeserializerMethod(element, beanName), makeNewSerializerMethod(element, beanName)) | ||
.collect(Collectors.toList()); | ||
} | ||
|
||
@Override | ||
protected void generateSerializer(TypeMirror beanType, String packageName, Name beanName) { | ||
new SerializerGenerator().generate(beanType, packageName, beanName); | ||
} | ||
|
||
@Override | ||
protected void generateDeserializer(TypeMirror beanType, String packageName, Name beanName) { | ||
new DeserializerGenerator().generate(beanType, packageName, beanName); | ||
} | ||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The unused import needs to be removed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, I will fix unused imports.