[feat] 이메일 인증 기능 구현 #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RyuKwanKon
approved these changes
Dec 27, 2023
src/main/java/org/gachon/checkmate/domain/member/service/MemberService.java
Show resolved
Hide resolved
src/main/java/org/gachon/checkmate/domain/member/controller/MemberController.java
Outdated
Show resolved
Hide resolved
OJOJIN
reviewed
Dec 27, 2023
| } | ||
| } | ||
|
|
||
| public static String createNumericCode() { |
There was a problem hiding this comment.
Memeber Service 내부에서만 사용한다면 private으로만 둬도 괜찮을 것 같아요
| return code.toString(); | ||
| } | ||
|
|
||
| public String setContext(String code, String type) { |
There was a problem hiding this comment.
위와 동일하게 Memeber Service 내부에서만 사용한다면 private으로만 둬도 괜찮을 것 같아요
There was a problem hiding this comment.
두 함수 둘 다 mail provider로 옮긴 뒤 제어자 private로 고쳤습니다 ㅎ.ㅎ 감사합니다 !!!!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue 🪢
Summary 🌿
Before i request PR review 🧤