Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft fix old ci #1822

Closed
wants to merge 234 commits into from
Closed

Conversation

eleanorjboyd
Copy link
Contributor

potential fix - need to run against CI

heejaechang and others added 30 commits March 22, 2023 10:57
it turns out the new telemetry API removed a way to set extension id and
version when telemetry reporter is created and it implicitly sets from
extension reporter is created. the same way how LSP client is working.

since we want to keep using the same extension id and etc for our
telemetry, we need the reporter created from core ext.
For #20899 (+ a few
other strings I thought could use some tweaking too)
fixes #20909

Activating `pylance` extension inside of `python` extension cause a dead
lock since they have circular dependency. now we make sure we activate
`pylance` once `python` extension is activated.

`node` already works this way. it is just browser extension that started
`pylance` inside `activate` directly.
This is addressing an internal CG issue.
@luabud This PR adds a minor telemetry change to create environment.
There is a new telemetry point indicating pip upgrade.
For #18073

---------

Co-authored-by: Brett Cannon <brett@python.org>
Fix lint in api.ts
Karthik brought this up offline and I agree, instead of saying we don't
offer support out of box, we say it needs to be via the Jupyter
extension.
…ing along with terminal env var experiment (#20952)

I initially deprecated this setting as I thought folks only disabled it
because we were sending commands which was annoying.
Fixes #19359

---------

Co-authored-by: Kartik Raj <karraj@microsoft.com>
switches to using the UUID of the discover/run call for unittest and
pytest instead of the CWD. This allows for multiple calls from single
workspace to be handled.
UUID is now handled by the adapter therefore is added to options sent to
the server from the adapter.

Since the UUID is no longer being added by the server, the server tests
should no longer test if the server is correctly handling the UUID. This
logic is now passed to the adapter and therefore tests related to
processing non-existent UUID and UUID not currently active is the
adapters role.
This PR contains:
1. `microvenv` fallback if `venv` is not available (implemented in
python with tests)
2. Updates to telemetry to include microvenv.

Closes #20905
Bumps [actions/checkout](https://github.com/actions/checkout) from 2 to
3.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a
href="https://github.com/actions/checkout/releases">actions/checkout's
releases</a>.</em></p>
<blockquote>
<h2>v3.0.0</h2>
<ul>
<li>Updated to the node16 runtime by default
<ul>
<li>This requires a minimum <a
href="https://github.com/actions/runner/releases/tag/v2.285.0">Actions
Runner</a> version of v2.285.0 to run, which is by default available in
GHES 3.4 or later.</li>
</ul>
</li>
</ul>
<h2>v2.7.0</h2>
<h2>What's Changed</h2>
<ul>
<li>Add new public key for known_hosts (<a
href="https://redirect.github.com/actions/checkout/issues/1237">#1237</a>)
by <a
href="https://github.com/TingluoHuang"><code>@​TingluoHuang</code></a>
in <a
href="https://redirect.github.com/actions/checkout/pull/1238">actions/checkout#1238</a></li>
</ul>
<p><strong>Full Changelog</strong>: <a
href="https://github.com/actions/checkout/compare/v2.6.0...v2.7.0">https://github.com/actions/checkout/compare/v2.6.0...v2.7.0</a></p>
<h2>v2.6.0</h2>
<h2>What's Changed</h2>
<ul>
<li>Add backports to v2 branch by <a
href="https://github.com/cory-miller"><code>@​cory-miller</code></a> in
<a
href="https://redirect.github.com/actions/checkout/pull/1040">actions/checkout#1040</a>
<ul>
<li>Includes backports from the following changes: <a
href="https://redirect.github.com/actions/checkout/pull/964">actions/checkout#964</a>,
<a
href="https://redirect.github.com/actions/checkout/pull/1002">actions/checkout#1002</a>,
<a
href="https://redirect.github.com/actions/checkout/pull/1029">actions/checkout#1029</a></li>
<li>Upgraded the licensed version to match what is used in v3.</li>
</ul>
</li>
</ul>
<p><strong>Full Changelog</strong>: <a
href="https://github.com/actions/checkout/compare/v2.5.0...v2.6.0">https://github.com/actions/checkout/compare/v2.5.0...v2.6.0</a></p>
<h2>v2.5.0</h2>
<h2>What's Changed</h2>
<ul>
<li>Update <code>@​actions/core</code> to 1.10.0 by <a
href="https://github.com/rentziass"><code>@​rentziass</code></a> in <a
href="https://redirect.github.com/actions/checkout/pull/962">actions/checkout#962</a></li>
</ul>
<p><strong>Full Changelog</strong>: <a
href="https://github.com/actions/checkout/compare/v2...v2.5.0">https://github.com/actions/checkout/compare/v2...v2.5.0</a></p>
<h2>v2.4.2</h2>
<h2>What's Changed</h2>
<ul>
<li>Add set-safe-directory input to allow customers to take control. (<a
href="https://redirect.github.com/actions/checkout/issues/770">#770</a>)
by <a
href="https://github.com/TingluoHuang"><code>@​TingluoHuang</code></a>
in <a
href="https://redirect.github.com/actions/checkout/pull/776">actions/checkout#776</a></li>
<li>Prepare changelog for v2.4.2. by <a
href="https://github.com/TingluoHuang"><code>@​TingluoHuang</code></a>
in <a
href="https://redirect.github.com/actions/checkout/pull/778">actions/checkout#778</a></li>
</ul>
<p><strong>Full Changelog</strong>: <a
href="https://github.com/actions/checkout/compare/v2...v2.4.2">https://github.com/actions/checkout/compare/v2...v2.4.2</a></p>
<h2>v2.4.1</h2>
<ul>
<li>Fixed an issue where checkout failed to run in container jobs due to
the new git setting <code>safe.directory</code></li>
</ul>
<h2>v2.4.0</h2>
<ul>
<li>Convert SSH URLs like <code>org-&lt;ORG_ID&gt;@github.com:</code> to
<code>https://github.com/</code> - <a
href="https://redirect.github.com/actions/checkout/pull/621">pr</a></li>
</ul>
<h2>v2.3.5</h2>
<p>Update dependencies</p>
<h2>v2.3.4</h2>
<ul>
<li><a href="https://redirect.github.com/actions/checkout/pull/379">Add
missing <code>await</code>s</a></li>
<li><a href="https://redirect.github.com/actions/checkout/pull/360">Swap
to Environment Files</a></li>
</ul>
<h2>v2.3.3</h2>
<ul>
<li><a
href="https://redirect.github.com/actions/checkout/pull/345">Remove
Unneeded commit information from build logs</a></li>
<li><a href="https://redirect.github.com/actions/checkout/pull/326">Add
Licensed to verify third party dependencies</a></li>
</ul>
<!-- raw HTML omitted -->
</blockquote>
<p>... (truncated)</p>
</details>
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a
href="https://github.com/actions/checkout/blob/main/CHANGELOG.md">actions/checkout's
changelog</a>.</em></p>
<blockquote>
<h1>Changelog</h1>
<h2>v3.4.0</h2>
<ul>
<li><a
href="https://redirect.github.com/actions/checkout/pull/1209">Upgrade
codeql actions to v2</a></li>
<li><a
href="https://redirect.github.com/actions/checkout/pull/1210">Upgrade
dependencies</a></li>
<li><a
href="https://redirect.github.com/actions/checkout/pull/1225">Upgrade
<code>@​actions/io</code></a></li>
</ul>
<h2>v3.3.0</h2>
<ul>
<li><a
href="https://redirect.github.com/actions/checkout/pull/1045">Implement
branch list using callbacks from exec function</a></li>
<li><a href="https://redirect.github.com/actions/checkout/pull/1050">Add
in explicit reference to private checkout options</a></li>
<li>[Fix comment typos (that got added in <a
href="https://redirect.github.com/actions/checkout/issues/770">#770</a>)](<a
href="https://redirect.github.com/actions/checkout/pull/1057">actions/checkout#1057</a>)</li>
</ul>
<h2>v3.2.0</h2>
<ul>
<li><a href="https://redirect.github.com/actions/checkout/pull/942">Add
GitHub Action to perform release</a></li>
<li><a href="https://redirect.github.com/actions/checkout/pull/967">Fix
status badge</a></li>
<li><a
href="https://redirect.github.com/actions/checkout/pull/1002">Replace
datadog/squid with ubuntu/squid Docker image</a></li>
<li><a href="https://redirect.github.com/actions/checkout/pull/964">Wrap
pipeline commands for submoduleForeach in quotes</a></li>
<li><a
href="https://redirect.github.com/actions/checkout/pull/1029">Update
<code>@​actions/io</code> to 1.1.2</a></li>
<li><a
href="https://redirect.github.com/actions/checkout/pull/1039">Upgrading
version to 3.2.0</a></li>
</ul>
<h2>v3.1.0</h2>
<ul>
<li><a href="https://redirect.github.com/actions/checkout/pull/939">Use
<code>@​actions/core</code> <code>saveState</code> and
<code>getState</code></a></li>
<li><a href="https://redirect.github.com/actions/checkout/pull/922">Add
<code>github-server-url</code> input</a></li>
</ul>
<h2>v3.0.2</h2>
<ul>
<li><a href="https://redirect.github.com/actions/checkout/pull/770">Add
input <code>set-safe-directory</code></a></li>
</ul>
<h2>v3.0.1</h2>
<ul>
<li><a
href="https://redirect.github.com/actions/checkout/pull/762">Fixed an
issue where checkout failed to run in container jobs due to the new git
setting <code>safe.directory</code></a></li>
<li><a
href="https://redirect.github.com/actions/checkout/pull/744">Bumped
various npm package versions</a></li>
</ul>
<h2>v3.0.0</h2>
<ul>
<li><a
href="https://redirect.github.com/actions/checkout/pull/689">Update to
node 16</a></li>
</ul>
<h2>v2.3.1</h2>
<ul>
<li><a href="https://redirect.github.com/actions/checkout/pull/284">Fix
default branch resolution for .wiki and when using SSH</a></li>
</ul>
<h2>v2.3.0</h2>
<ul>
<li><a
href="https://redirect.github.com/actions/checkout/pull/278">Fallback to
the default branch</a></li>
</ul>
<h2>v2.2.0</h2>
<ul>
<li><a
href="https://redirect.github.com/actions/checkout/pull/258">Fetch all
history for all tags and branches when fetch-depth=0</a></li>
</ul>
<h2>v2.1.1</h2>
<ul>
<li>Changes to support GHES (<a
href="https://redirect.github.com/actions/checkout/pull/236">here</a>
and <a
href="https://redirect.github.com/actions/checkout/pull/248">here</a>)</li>
</ul>
<!-- raw HTML omitted -->
</blockquote>
<p>... (truncated)</p>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a
href="https://github.com/actions/checkout/commit/8f4b7f84864484a7bf31766abe9204da3cbe65b3"><code>8f4b7f8</code></a>
Add new public key for known_hosts (<a
href="https://redirect.github.com/actions/checkout/issues/1237">#1237</a>)</li>
<li><a
href="https://github.com/actions/checkout/commit/cd6a9fd49371476d813e892956e2e920fcc3fb7e"><code>cd6a9fd</code></a>
Update update-main-version.yml</li>
<li><a
href="https://github.com/actions/checkout/commit/24cb9080177205b6e8c946b17badbe402adc938f"><code>24cb908</code></a>
Bump <code>@​actions/io</code> to v1.1.3 (<a
href="https://redirect.github.com/actions/checkout/issues/1225">#1225</a>)</li>
<li><a
href="https://github.com/actions/checkout/commit/27135e314dd1818f797af1db9dae03a9f045786b"><code>27135e3</code></a>
Upgrade dependencies (<a
href="https://redirect.github.com/actions/checkout/issues/1210">#1210</a>)</li>
<li><a
href="https://github.com/actions/checkout/commit/7b187184d12a8f064f797aeb51e4873c109637c7"><code>7b18718</code></a>
Upgrade codeql actions to v2 (<a
href="https://redirect.github.com/actions/checkout/issues/1209">#1209</a>)</li>
<li><a
href="https://github.com/actions/checkout/commit/ac593985615ec2ede58e132d2e21d2b1cbd6127c"><code>ac59398</code></a>
Fix comment typos (that got added in <a
href="https://redirect.github.com/actions/checkout/issues/770">#770</a>)
(<a
href="https://redirect.github.com/actions/checkout/issues/1057">#1057</a>)</li>
<li><a
href="https://github.com/actions/checkout/commit/3ba5ee6fac7e0e30e2ea884e236f282d3a775891"><code>3ba5ee6</code></a>
Add in explicit reference to private checkout options (<a
href="https://redirect.github.com/actions/checkout/issues/1050">#1050</a>)</li>
<li><a
href="https://github.com/actions/checkout/commit/885641592076c27bfb56c028cd5612cdad63e16d"><code>8856415</code></a>
Implement branch list using callbacks from exec function (<a
href="https://redirect.github.com/actions/checkout/issues/1045">#1045</a>)</li>
<li><a
href="https://github.com/actions/checkout/commit/755da8c3cf115ac066823e79a1e1788f8940201b"><code>755da8c</code></a>
3.2.0 (<a
href="https://redirect.github.com/actions/checkout/issues/1039">#1039</a>)</li>
<li><a
href="https://github.com/actions/checkout/commit/26d48e8ea150211a9bc3b1f0c20448599687d926"><code>26d48e8</code></a>
Update <code>@​actions/io</code> to 1.1.2 (<a
href="https://redirect.github.com/actions/checkout/issues/1029">#1029</a>)</li>
<li>Additional commits viewable in <a
href="https://github.com/actions/checkout/compare/v2...v3">compare
view</a></li>
</ul>
</details>
<br />


[![Dependabot compatibility
score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=actions/checkout&package-manager=github_actions&previous-version=2&new-version=3)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't
alter it yourself. You can also trigger a rebase manually by commenting
`@dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits
that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after
your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge
and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating
it. You can achieve the same result by closing it manually
- `@dependabot ignore this major version` will close this PR and stop
Dependabot creating any more for this major version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop
Dependabot creating any more for this minor version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop
Dependabot creating any more for this dependency (unless you reopen the
PR or upgrade to it yourself)


</details>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [actions/github-script](https://github.com/actions/github-script)
from 4 to 6.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a
href="https://github.com/actions/github-script/releases">actions/github-script's
releases</a>.</em></p>
<blockquote>
<h2>v6.0.0</h2>
<h2>What's Changed</h2>
<ul>
<li>Update default runtime to node16 by <a
href="https://github.com/thboop"><code>@​thboop</code></a> in <a
href="https://redirect.github.com/actions/github-script/pull/235">actions/github-script#235</a></li>
<li>Update <code>node-fetch</code> by <a
href="https://github.com/joshmgross"><code>@​joshmgross</code></a> in <a
href="https://redirect.github.com/actions/github-script/pull/237">actions/github-script#237</a></li>
<li>Update <code>@actions/core</code> to 1.6.0 by <a
href="https://github.com/joshmgross"><code>@​joshmgross</code></a> in <a
href="https://redirect.github.com/actions/github-script/pull/238">actions/github-script#238</a></li>
</ul>
<h3>Breaking Changes</h3>
<p>With the update to Node 16 in <a
href="https://redirect.github.com/actions/github-script/issues/235">#235</a>,
all scripts will now be run with Node 16 rather than Node 12.</p>
<h2>New Contributors</h2>
<ul>
<li><a href="https://github.com/thboop"><code>@​thboop</code></a> made
their first contribution in <a
href="https://redirect.github.com/actions/github-script/pull/235">actions/github-script#235</a></li>
</ul>
<p><strong>Full Changelog</strong>: <a
href="https://github.com/actions/github-script/compare/v5...v6.0.0">https://github.com/actions/github-script/compare/v5...v6.0.0</a></p>
<h2>v5.2.0</h2>
<h2>What's Changed</h2>
<ul>
<li>Upgrade <code>@​actions/core</code> to 1.10.0 for v5 by <a
href="https://github.com/rentziass"><code>@​rentziass</code></a> in <a
href="https://redirect.github.com/actions/github-script/pull/350">actions/github-script#350</a></li>
</ul>
<p><strong>Full Changelog</strong>: <a
href="https://github.com/actions/github-script/compare/v5.1.1...v5.2.0">https://github.com/actions/github-script/compare/v5.1.1...v5.2.0</a></p>
<h2>v5.1.1</h2>
<h2>What's Changed</h2>
<ul>
<li>Bump <code>@​actions/core</code> to 1.9.1 by <a
href="https://github.com/cory-miller"><code>@​cory-miller</code></a> in
<a
href="https://redirect.github.com/actions/github-script/pull/281">actions/github-script#281</a></li>
</ul>
<p><strong>Full Changelog</strong>: <a
href="https://github.com/actions/github-script/compare/v5.1.0...v5.1.1">https://github.com/actions/github-script/compare/v5.1.0...v5.1.1</a></p>
<h2>v5.1.0</h2>
<h2>What's Changed</h2>
<ul>
<li>Update to latest versions for dev dependencies by <a
href="https://github.com/joshmgross"><code>@​joshmgross</code></a> in <a
href="https://redirect.github.com/actions/github-script/pull/204">actions/github-script#204</a></li>
<li>update plugin dependencies by <a
href="https://github.com/PeterNitscheMI"><code>@​PeterNitscheMI</code></a>
in <a
href="https://redirect.github.com/actions/github-script/pull/216">actions/github-script#216</a></li>
<li>Update licenses and use <code>jonabc/setup-licensed</code> in
workflow by <a
href="https://github.com/joshmgross"><code>@​joshmgross</code></a> in <a
href="https://redirect.github.com/actions/github-script/pull/228">actions/github-script#228</a></li>
</ul>
<h2>New Contributors</h2>
<ul>
<li><a
href="https://github.com/johan-lindqvist"><code>@​johan-lindqvist</code></a>
made their first contribution in <a
href="https://redirect.github.com/actions/github-script/pull/201">actions/github-script#201</a></li>
<li><a href="https://github.com/ansgarm"><code>@​ansgarm</code></a> made
their first contribution in <a
href="https://redirect.github.com/actions/github-script/pull/215">actions/github-script#215</a></li>
<li><a
href="https://github.com/PeterNitscheMI"><code>@​PeterNitscheMI</code></a>
made their first contribution in <a
href="https://redirect.github.com/actions/github-script/pull/216">actions/github-script#216</a></li>
</ul>
<p><strong>Full Changelog</strong>: <a
href="https://github.com/actions/github-script/compare/v5.0.0...v5.1.0">https://github.com/actions/github-script/compare/v5.0.0...v5.1.0</a></p>
<h2>v5.0.0</h2>
<h2>What's Changed</h2>
<ul>
<li>Upgrade to the latest version of Octokit by <a
href="https://github.com/joshmgross"><code>@​joshmgross</code></a> in <a
href="https://redirect.github.com/actions/github-script/pull/193">actions/github-script#193</a>
(Thanks to <a
href="https://github.com/IronSean"><code>@​IronSean</code></a> for
contributing to this fix)</li>
</ul>
<h2>Breaking Changes</h2>
<p>As part of this update, the Octokit context available via
<code>github</code> no longer has REST methods directly. These methods
are available via <code>github.rest.*</code> - <a
href="https://github.com/octokit/plugin-rest-endpoint-methods.js/releases/tag/v5.0.0">https://github.com/octokit/plugin-rest-endpoint-methods.js/releases/tag/v5.0.0</a></p>
<!-- raw HTML omitted -->
</blockquote>
<p>... (truncated)</p>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a
href="https://github.com/actions/github-script/commit/98814c53be79b1d30f795b907e553d8679345975"><code>98814c5</code></a>
Merge pull request <a
href="https://redirect.github.com/actions/github-script/issues/339">#339</a>
from actions/joshmgross/bump-package-version</li>
<li><a
href="https://github.com/actions/github-script/commit/ba6cf3fe7cf53f06998ea428adfe8f0da42d62fa"><code>ba6cf3f</code></a>
Bump version to 6.4.0</li>
<li><a
href="https://github.com/actions/github-script/commit/bcc389184da6172665613604320b19b409a8c941"><code>bcc3891</code></a>
Merge pull request <a
href="https://redirect.github.com/actions/github-script/issues/321">#321</a>
from danmichaelo/node-fetch</li>
<li><a
href="https://github.com/actions/github-script/commit/da8818015eb5c3d01f8ad6db6bd8e3a2b460c71c"><code>da88180</code></a>
Merge <code>main</code></li>
<li><a
href="https://github.com/actions/github-script/commit/4d93f388900dddc32a5a278a0ff985a0f06ca5c8"><code>4d93f38</code></a>
Update dist and audit deps</li>
<li><a
href="https://github.com/actions/github-script/commit/0550e858012a6d3a73fbdd735e96b8e4c35e5a9d"><code>0550e85</code></a>
Merge pull request <a
href="https://redirect.github.com/actions/github-script/issues/336">#336</a>
from actions/joshmgross/minimatch-license</li>
<li><a
href="https://github.com/actions/github-script/commit/5420835fff8001a224a310d320b6e02eed0713d8"><code>5420835</code></a>
Merge branch 'main' into joshmgross/minimatch-license</li>
<li><a
href="https://github.com/actions/github-script/commit/03377835c3717d8126c1d93eaaa72b55287f783d"><code>0337783</code></a>
Merge pull request <a
href="https://redirect.github.com/actions/github-script/issues/338">#338</a>
from actions/joshmgross/fix-dist</li>
<li><a
href="https://github.com/actions/github-script/commit/8c6dda0186c7ac8a53030e285851d54aabcd3620"><code>8c6dda0</code></a>
Regenerate <code>dist</code></li>
<li><a
href="https://github.com/actions/github-script/commit/ee0d992b062bc63a761e39c472f63aa0865b1e41"><code>ee0d992</code></a>
Use Node 16 in CI and examples</li>
<li>Additional commits viewable in <a
href="https://github.com/actions/github-script/compare/v4...v6">compare
view</a></li>
</ul>
</details>
<br />


[![Dependabot compatibility
score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=actions/github-script&package-manager=github_actions&previous-version=4&new-version=6)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't
alter it yourself. You can also trigger a rebase manually by commenting
`@dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits
that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after
your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge
and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating
it. You can achieve the same result by closing it manually
- `@dependabot ignore this major version` will close this PR and stop
Dependabot creating any more for this major version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop
Dependabot creating any more for this minor version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop
Dependabot creating any more for this dependency (unless you reopen the
PR or upgrade to it yourself)


</details>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps
[peter-evans/create-or-update-comment](https://github.com/peter-evans/create-or-update-comment)
from 2 to 3.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a
href="https://github.com/peter-evans/create-or-update-comment/releases">peter-evans/create-or-update-comment's
releases</a>.</em></p>
<blockquote>
<h2>Create or Update Comment v3.0.0</h2>
<h2>What's new</h2>
<ul>
<li>Now supports replacing reactions on a comment by setting input
<code>reactions-edit-mode</code> to <code>replace</code>. The default
behaviour has not changed and will <code>append</code> reactions.</li>
<li>Chose how the action should append the comment body with input
<code>append-separator</code>. The default behaviour is to add a
<code>newline</code>. Other options are <code>space</code> and
<code>none</code>.</li>
<li><code>body-file</code> is deprecated in favour of
<code>body-path</code>. The behaviour is unchanged.</li>
</ul>
<h2>What's Changed</h2>
<ul>
<li>v3 by <a
href="https://github.com/peter-evans"><code>@​peter-evans</code></a> in
<a
href="https://redirect.github.com/peter-evans/create-or-update-comment/pull/161">peter-evans/create-or-update-comment#161</a></li>
<li>Update some links in the README by <a
href="https://github.com/Kurt-von-Laven"><code>@​Kurt-von-Laven</code></a>
in <a
href="https://redirect.github.com/peter-evans/create-or-update-comment/pull/152">peter-evans/create-or-update-comment#152</a></li>
<li>9 dependency updates by <a
href="https://github.com/dependabot"><code>@​dependabot</code></a></li>
</ul>
<h2>New Contributors</h2>
<ul>
<li><a
href="https://github.com/Kurt-von-Laven"><code>@​Kurt-von-Laven</code></a>
made their first contribution in <a
href="https://redirect.github.com/peter-evans/create-or-update-comment/pull/152">peter-evans/create-or-update-comment#152</a></li>
</ul>
<p><strong>Full Changelog</strong>: <a
href="https://github.com/peter-evans/create-or-update-comment/compare/v2.1.1...v3.0.0">https://github.com/peter-evans/create-or-update-comment/compare/v2.1.1...v3.0.0</a></p>
<h2>Create or Update Comment v2.1.1</h2>
<p>⚙️ Fixes the recent Json5 vulnerability.</p>
<h2>What's Changed</h2>
<ul>
<li>11 dependency updates by <a
href="https://github.com/dependabot"><code>@​dependabot</code></a></li>
</ul>
<p><strong>Full Changelog</strong>: <a
href="https://github.com/peter-evans/create-or-update-comment/compare/v2.1.0...v2.1.1">https://github.com/peter-evans/create-or-update-comment/compare/v2.1.0...v2.1.1</a></p>
<h2>Create or Update Comment v2.1.0</h2>
<p>⭐ Adds input <code>body-file</code>, the path to a file containing
the comment body.</p>
<h2>What's Changed</h2>
<ul>
<li>Replace set-output by <a
href="https://github.com/peter-evans"><code>@​peter-evans</code></a> in
<a
href="https://redirect.github.com/peter-evans/create-or-update-comment/pull/130">peter-evans/create-or-update-comment#130</a></li>
<li>Bump chuhlomin/render-template from 1.5 to 1.6 by <a
href="https://github.com/dependabot"><code>@​dependabot</code></a> in <a
href="https://redirect.github.com/peter-evans/create-or-update-comment/pull/132">peter-evans/create-or-update-comment#132</a></li>
<li>Support reading body from a file by <a
href="https://github.com/umanghome"><code>@​umanghome</code></a> in <a
href="https://redirect.github.com/peter-evans/create-or-update-comment/pull/115">peter-evans/create-or-update-comment#115</a></li>
<li>Add input body-file by <a
href="https://github.com/peter-evans"><code>@​peter-evans</code></a> in
<a
href="https://redirect.github.com/peter-evans/create-or-update-comment/pull/133">peter-evans/create-or-update-comment#133</a></li>
</ul>
<h2>New Contributors</h2>
<ul>
<li><a href="https://github.com/umanghome"><code>@​umanghome</code></a>
made their first contribution in <a
href="https://redirect.github.com/peter-evans/create-or-update-comment/pull/115">peter-evans/create-or-update-comment#115</a></li>
</ul>
<p><strong>Full Changelog</strong>: <a
href="https://github.com/peter-evans/create-or-update-comment/compare/v2.0.1...v2.1.0">https://github.com/peter-evans/create-or-update-comment/compare/v2.0.1...v2.1.0</a></p>
<h2>Create or Update Comment v2.0.1</h2>
<p>⚙️ Bumps <code>@actions/core</code> to transition away from <a
href="https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/">deprecated
runner commands</a>.</p>
<h2>What's Changed</h2>
<ul>
<li>Add workflow permissions by <a
href="https://github.com/peter-evans"><code>@​peter-evans</code></a> in
<a
href="https://redirect.github.com/peter-evans/create-or-update-comment/pull/120">peter-evans/create-or-update-comment#120</a></li>
<li>9 dependency updates by <a
href="https://github.com/github-actions"><code>@​github-actions</code></a>
and <a
href="https://github.com/dependabot">https://github.com/dependabot</a></li>
</ul>
<p><strong>Full Changelog</strong>: <a
href="https://github.com/peter-evans/create-or-update-comment/compare/v2.0.0...v2.0.1">https://github.com/peter-evans/create-or-update-comment/compare/v2.0.0...v2.0.1</a></p>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a
href="https://github.com/peter-evans/create-or-update-comment/commit/3383acd359705b10cb1eeef05c0e88c056ea4666"><code>3383acd</code></a>
v3 (<a
href="https://redirect.github.com/peter-evans/create-or-update-comment/issues/161">#161</a>)</li>
<li><a
href="https://github.com/peter-evans/create-or-update-comment/commit/9c6357680f5ea232e8afaf4efc0cc92367110d78"><code>9c63576</code></a>
Bump peter-evans/create-pull-request from 4 to 5 (<a
href="https://redirect.github.com/peter-evans/create-or-update-comment/issues/163">#163</a>)</li>
<li><a
href="https://github.com/peter-evans/create-or-update-comment/commit/3d6c0b9c6c6128c3f7fc6f873c0218915585ff51"><code>3d6c0b9</code></a>
ci: add missing checkout step</li>
<li><a
href="https://github.com/peter-evans/create-or-update-comment/commit/1fcda994df6b557d6ae3d3afbd8b4c55bbd14f29"><code>1fcda99</code></a>
ci: add test v3 workflow</li>
<li><a
href="https://github.com/peter-evans/create-or-update-comment/commit/5f728c3dae25f329afbe34ee4d08eef25569d79f"><code>5f728c3</code></a>
Bump peter-evans/enable-pull-request-automerge from 2 to 3 (<a
href="https://redirect.github.com/peter-evans/create-or-update-comment/issues/160">#160</a>)</li>
<li><a
href="https://github.com/peter-evans/create-or-update-comment/commit/fd9e73cdb111244f59c4bdf94994545011a0d89c"><code>fd9e73c</code></a>
Bump eslint from 8.36.0 to 8.37.0 (<a
href="https://redirect.github.com/peter-evans/create-or-update-comment/issues/159">#159</a>)</li>
<li><a
href="https://github.com/peter-evans/create-or-update-comment/commit/384c114887453534544cab66743e0ed42a1342a8"><code>384c114</code></a>
Bump eslint from 8.35.0 to 8.36.0 (<a
href="https://redirect.github.com/peter-evans/create-or-update-comment/issues/155">#155</a>)</li>
<li><a
href="https://github.com/peter-evans/create-or-update-comment/commit/44526e38b60c3be1ea27a6cd6f7359f7ce3f6bc8"><code>44526e3</code></a>
Bump jest from 29.4.3 to 29.5.0 (<a
href="https://redirect.github.com/peter-evans/create-or-update-comment/issues/154">#154</a>)</li>
<li><a
href="https://github.com/peter-evans/create-or-update-comment/commit/b1fa5d531f73c67e1ab3962d1c16764f188066a6"><code>b1fa5d5</code></a>
Bump eslint from 8.34.0 to 8.35.0 (<a
href="https://redirect.github.com/peter-evans/create-or-update-comment/issues/153">#153</a>)</li>
<li><a
href="https://github.com/peter-evans/create-or-update-comment/commit/c5a7a9808bb4d6de79278436482399ce9a4de9d5"><code>c5a7a98</code></a>
Merge pull request <a
href="https://redirect.github.com/peter-evans/create-or-update-comment/issues/152">#152</a>
from Kurt-von-Laven/patch-1</li>
<li>Additional commits viewable in <a
href="https://github.com/peter-evans/create-or-update-comment/compare/v2...v3">compare
view</a></li>
</ul>
</details>
<br />


[![Dependabot compatibility
score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=peter-evans/create-or-update-comment&package-manager=github_actions&previous-version=2&new-version=3)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't
alter it yourself. You can also trigger a rebase manually by commenting
`@dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits
that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after
your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge
and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating
it. You can achieve the same result by closing it manually
- `@dependabot ignore this major version` will close this PR and stop
Dependabot creating any more for this major version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop
Dependabot creating any more for this minor version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop
Dependabot creating any more for this dependency (unless you reopen the
PR or upgrade to it yourself)


</details>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
brettcannon and others added 29 commits August 3, 2023 00:14
fix spelling from get_pip to get-pip as advised.
revert #21667 because it
causes buffer overflow in the python testing subprocess when larger
repos are used. Specifically seen on pytest discovery with >200 tests.
Revert to align with the stable release and put in a fix next week.
…all vscode types separately (#21764)

Closes It still leads to conflicts due to double installation of vscode
types when testing through the cases, removing vscode types as
dependencies altogether and documenting to install it separately
instead.
Add Ruff to (lint > action.yml) CI
#21738
Bumps
[brettcannon/check-for-changed-files](https://github.com/brettcannon/check-for-changed-files)
from 1.1.1 to 1.2.0.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a
href="https://github.com/brettcannon/check-for-changed-files/releases">brettcannon/check-for-changed-files's
releases</a>.</em></p>
<blockquote>
<h2>v1.2.0</h2>
<h2>What's Changed</h2>
<ul>
<li>Add support for github tokens for private repos. by <a
href="https://github.com/Marenz"><code>@​Marenz</code></a> in <a
href="https://redirect.github.com/brettcannon/check-for-changed-files/pull/83">brettcannon/check-for-changed-files#83</a></li>
</ul>
<h2>New Contributors</h2>
<ul>
<li><a href="https://github.com/Marenz"><code>@​Marenz</code></a> made
their first contribution in <a
href="https://redirect.github.com/brettcannon/check-for-changed-files/pull/83">brettcannon/check-for-changed-files#83</a></li>
</ul>
<p><strong>Full Changelog</strong>: <a
href="https://github.com/brettcannon/check-for-changed-files/compare/v1...v1.2.0">https://github.com/brettcannon/check-for-changed-files/compare/v1...v1.2.0</a></p>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a
href="https://github.com/brettcannon/check-for-changed-files/commit/4170644959a21843b31f1181f2a1761d65ef4791"><code>4170644</code></a>
Add support for github tokens for private repos. (<a
href="https://redirect.github.com/brettcannon/check-for-changed-files/issues/83">#83</a>)</li>
<li><a
href="https://github.com/brettcannon/check-for-changed-files/commit/294a99714e0d350b5083472a293d41bc91804e68"><code>294a997</code></a>
Bump word-wrap from 1.2.3 to 1.2.4 (<a
href="https://redirect.github.com/brettcannon/check-for-changed-files/issues/82">#82</a>)</li>
<li>See full diff in <a
href="https://github.com/brettcannon/check-for-changed-files/compare/v1.1.1...v1.2.0">compare
view</a></li>
</ul>
</details>
<br />


[![Dependabot compatibility
score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=brettcannon/check-for-changed-files&package-manager=github_actions&previous-version=1.1.1&new-version=1.2.0)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't
alter it yourself. You can also trigger a rebase manually by commenting
`@dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits
that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after
your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge
and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating
it. You can achieve the same result by closing it manually
- `@dependabot ignore this major version` will close this PR and stop
Dependabot creating any more for this major version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop
Dependabot creating any more for this minor version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop
Dependabot creating any more for this dependency (unless you reopen the
PR or upgrade to it yourself)


</details>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
For microsoft/vscode#171173
#20822

To be merged tomorrow when latest insiders is released. Blocked on
microsoft/vscode#189979.
This PR adds app name to the editor_load telemetry event
file `service.test.ts` was calling to dispose of all items related to
the service container for clean up. This led to services in later tests
failing since they were close already. Fixes here allow for new tests in
the test adapter to be written.

fix helps #21803
This merges in two PRs that were reverted because of a bug introduced
that caused subprocess overflow.
reverted PRs: #21667,
#21682

This now implements these two PRs allowing for absolute testIds and an
execObservable for the subprocess. This PR also adds a bug fix and
functional tests to ensure this doesn't happen again.

Since this PR is large, all items in it have already been reviewed as
they were merged into the feature branch.
…on when in `pythonTerminalEnvVarActivation` experiment (#21802)

Closes #21793

Only show notification when terminal prompt does not already indicate
that env is activated.
as per
https://docs.pytest.org/en/7.1.x/reference/reference.html#collectreport,
`CollectReport` is experimental and therefore it should not be in our
extension. Fixes #21784
For #21825

On codespaces, it was leading to workspace environments not being
displayed, which could mess up auto-selection.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet