Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check if eslint config should change prefer-arrow-callback setting #110

Open
JoernBerkefeld opened this issue May 11, 2022 · 4 comments
Open

Comments

@JoernBerkefeld
Copy link
Collaborator

somehow it's automatically turning arrow functions into old fashioned function notation for all tests.

https://eslint.org/docs/rules/prefer-arrow-callback

Originally posted by @JoernBerkefeld in #108 (comment)

@DougMidgley
Copy link
Owner

DougMidgley commented May 12, 2022

https://github.com/prettier/eslint-plugin-prettier#arrow-body-style-and-prefer-arrow-callback-issue basically covers this. In the interests of keeping the standards, prefer to keep OOTB recommendation

@JoernBerkefeld
Copy link
Collaborator Author

Wrong issue?

@DougMidgley
Copy link
Owner

Updated link:)

@JoernBerkefeld
Copy link
Collaborator Author

JoernBerkefeld commented May 17, 2022

Question remains why your 3 test classes are - across our 2 projects - the only place eslint/prettier auto-replaced this. I find that rather strange

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants