Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standardized Error Messages returned where possible #108

Conversation

DougMidgley
Copy link
Owner

PR details

What is the purpose of this pull request? (put an "X" next to an item)

  • Fix
  • Improvements
  • New Feature
  • Documentation updates
  • Other, please explain:

What changes did you make? (Give an overview)

Standardizes processing of errors to use CODE and MESSAGE where plausible

@DougMidgley DougMidgley linked an issue May 7, 2022 that may be closed by this pull request
@DougMidgley DougMidgley changed the base branch from main to develop May 7, 2022 12:12
@DougMidgley DougMidgley added the enhancement New feature or request label May 7, 2022
@JoernBerkefeld JoernBerkefeld self-requested a review May 7, 2022 22:43
lib/soap.js Outdated Show resolved Hide resolved
lib/rest.js Outdated Show resolved Hide resolved
lib/auth.js Outdated Show resolved Hide resolved
Copy link
Collaborator

@JoernBerkefeld JoernBerkefeld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i like how you've solved this :)

@JoernBerkefeld JoernBerkefeld merged commit d2c1a68 into develop May 11, 2022
@JoernBerkefeld JoernBerkefeld deleted the feature/106-weird-login-failed-soap-error-upon-retrieving-folders branch May 11, 2022 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

weird "Login failed" SOAP error upon retrieving folders
2 participants