Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add enderio translate(zh_cn) #6

Merged
merged 9 commits into from
Mar 16, 2019
Merged

Conversation

baka-gourd
Copy link
Contributor

Add enderio translate.

@baka-gourd
Copy link
Contributor Author

@brandon3055 ☺️

@baka-gourd
Copy link
Contributor Author

@brandon3055

1 similar comment
@baka-gourd
Copy link
Contributor Author

@brandon3055

@brandon3055
Copy link
Member

Sorry for the delay. As this PR contains changes that effect mods that are not my own i would like @HenryLoenwind or someone else from the ender IO team to review them before i merge this PR.

@HenryLoenwind
Copy link
Contributor

I don't read Chinese, so I can not really look at it properly. It only adds a Chinese translation, not changing the original, so I'd say it's fine.

@baka-gourd
Copy link
Contributor Author

I don't read Chinese, so I can not really look at it properly. It only adds a Chinese translation, not changing the original, so I'd say it's fine.

Yes, I know that. I have checked it several times before submitting.
I think it's not very good to insert small images in the document (like the icon of the ether wrench), which may affect reading.
And perhaps should this be combined to update the mod translation?

@brandon3055
Copy link
Member

@HenryLoenwind I'm pretty much the same way with my localisations. But given the nature of PI i want to get the OK from the developer of a mod before i pull changes. This process will be a lot easier if @covers1624 ever gets around to finishing PiBot.

@brandon3055 brandon3055 merged commit d46008e into Draconic-Inc:master Mar 16, 2019
@HenryLoenwind
Copy link
Contributor

sure and I appreciate it. I now turned notifications for this repo on so I'll notice it in the future without being pinged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants