Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

70 color options update #74

Closed
wants to merge 27 commits into from

Simple commit to check rules

caae9c5
Select commit
Loading
Failed to load commit list.
Closed

70 color options update #74

Simple commit to check rules
caae9c5
Select commit
Loading
Failed to load commit list.
Codacy Production / Codacy Static Code Analysis succeeded Jun 27, 2024 in 0s

Your pull request is up to standards!

Codacy Here is an overview of what got changed by this pull request:

Issues
======
+ Solved 33
- Added 36
           

Complexity increasing per file
==============================
- Spreadsheet/Components/2007/SpreadSheetCommonProperties.cs  1
- Presentation/Components/2007/PresentationCommonProperties.cs  1
- Spreadsheet/Components/2007/Shape.cs  2
- Spreadsheet/Parts/Drawing.cs  1
         

Clones added
============
- Spreadsheet/Components/2007/SpreadSheetCommonProperties.cs  1
- Presentation/Components/2007/PresentationCommonProperties.cs  1
         

Clones removed
==============
+ Spreadsheet/Parts/Worksheet.cs  -5
+ Presentation/Parts/CommonSlideData.cs  -2
         

See the complete overview on Codacy

Annotations

Check notice on line 665 in Global/Models/2007/ChartBaseModel.cs

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

Global/Models/2007/ChartBaseModel.cs#L665

Add underscores to this numeric value for readability.

Check notice on line 669 in Global/Models/2007/ChartBaseModel.cs

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

Global/Models/2007/ChartBaseModel.cs#L669

Remove this initialization to '_y', the compiler will do that for you.

Check notice on line 677 in Global/Models/2007/ChartBaseModel.cs

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

Global/Models/2007/ChartBaseModel.cs#L677

Make this an auto-implemented property and remove its backing field.

Check notice on line 692 in Global/Models/2007/ChartBaseModel.cs

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

Global/Models/2007/ChartBaseModel.cs#L692

Make this an auto-implemented property and remove its backing field.

Check warning on line 700 in Global/Models/2007/ChartBaseModel.cs

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

Global/Models/2007/ChartBaseModel.cs#L700

Remove this commented out code.

Check notice on line 707 in Global/Models/2007/ChartBaseModel.cs

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

Global/Models/2007/ChartBaseModel.cs#L707

Make this an auto-implemented property and remove its backing field.

Check warning on line 715 in Global/Models/2007/ChartBaseModel.cs

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

Global/Models/2007/ChartBaseModel.cs#L715

Remove this commented out code.

Check notice on line 722 in Global/Models/2007/ChartBaseModel.cs

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

Global/Models/2007/ChartBaseModel.cs#L722

Make this an auto-implemented property and remove its backing field.

Check warning on line 730 in Global/Models/2007/ChartBaseModel.cs

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

Global/Models/2007/ChartBaseModel.cs#L730

Remove this commented out code.

Check notice on line 115 in Global/Models/2007/ShapeModel.cs

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

Global/Models/2007/ShapeModel.cs#L115

Remove this interface or add members to it.

Check warning on line 179 in Global/Models/2007/ShapeModel.cs

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

Global/Models/2007/ShapeModel.cs#L179

Reduce the number of generic parameters in the 'ArrowShapeModel' class to no more than the 2 authorized.

Check notice on line 213 in Global/Models/2007/ShapeModel.cs

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

Global/Models/2007/ShapeModel.cs#L213

Add underscores to this numeric value for readability.

Check notice on line 217 in Global/Models/2007/ShapeModel.cs

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

Global/Models/2007/ShapeModel.cs#L217

Add underscores to this numeric value for readability.

Check notice on line 221 in Global/Models/2007/ShapeModel.cs

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

Global/Models/2007/ShapeModel.cs#L221

Add underscores to this numeric value for readability.

Check failure on line 51 in Presentation/Components/2007/Shape.cs

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

Presentation/Components/2007/Shape.cs#L51

Add a nested comment explaining why this method is empty, throw a 'NotSupportedException' or complete the implementation.

Check notice on line 187 in Presentation/Components/2007/Table.cs

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

Presentation/Components/2007/Table.cs#L187

Use the overload that takes a 'CultureInfo' or 'IFormatProvider' parameter.

Check notice on line 101 in Presentation/Parts/CommonSlideData.cs

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

Presentation/Parts/CommonSlideData.cs#L101

Add underscores to this numeric value for readability.

Check notice on line 102 in Presentation/Parts/CommonSlideData.cs

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

Presentation/Parts/CommonSlideData.cs#L102

Add underscores to this numeric value for readability.

Check notice on line 131 in Presentation/Parts/CommonSlideData.cs

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

Presentation/Parts/CommonSlideData.cs#L131

Add underscores to this numeric value for readability.

Check warning on line 88 in Spreadsheet/Components/2007/Chart.cs

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

Spreadsheet/Components/2007/Chart.cs#L88

Split this 204 characters long line (which is greater than 200 authorized).

Check notice on line 52 in Spreadsheet/Components/2007/Shape.cs

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

Spreadsheet/Components/2007/Shape.cs#L52

Remove the initializer; it is redundant.

Check warning on line 99 in Spreadsheet/Components/2007/Shape.cs

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

Spreadsheet/Components/2007/Shape.cs#L99

Rename 'twoCellAnchor' which hides the field with the same name.

Check notice on line 15 in Spreadsheet/Parts/Drawing.cs

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

Spreadsheet/Parts/Drawing.cs#L15

Change the name of type 'Drawing' to be different from an existing framework namespace.

Check warning on line 15 in Spreadsheet/Parts/Drawing.cs

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

Spreadsheet/Parts/Drawing.cs#L15

Split this class into smaller and more specialized ones to reduce its dependencies on other types from 31 to the maximum authorized 30 or less.

Check warning on line 106 in Tests/Presentation.cs

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

Tests/Presentation.cs#L106

Split this 222 characters long line (which is greater than 200 authorized).