Rework PubSub and fix race conditions #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 17 commits
December 6, 2023 12:07
- add aioredis_cluster.aioredis.stream module - rework PubSub command execution flow for prevent race conditions on spontaneously server channels unsubscribe push - make fully dedicated RedisConnection implementation for cluster - add key slot handling for sharded PubSub channels - fix and improve legacy aioredis tests - more tests
…ted channels for Cluster, Pool, RedisConnections
…ted channels for Cluster, Pool, RedisConnections
DriverX
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
aioredis_cluster.aioredis.streammoduleRedisConnectionimplementation for clusterRedisConnectiononce entered in PubSub mode was never exit in them, because is too hard handle spontaneously unsubscribe events from Redis with simultaneously(P|S)UNSUBSCRIBEmanually callsaioredistests