Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only build the XCFramework for the current configuration from Xcode #809

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mannodermaus
Copy link
Contributor

This prevents release frameworks from being built during debug, and vice versa.

Issue

Overview (Required)

  • Use the Xcode-provided environment variable $CONFIGURATION to determine whether to assemble the debug or release variant of the XCFramework

@github-actions github-actions bot temporarily deployed to deploygate-distribution August 25, 2024 23:39 Inactive
@mannodermaus mannodermaus force-pushed the kaizen/build-active-xcframework-only branch from 8a8feaf to df9d44b Compare August 25, 2024 23:41
This prevents release frameworks from being built during debug, and vice versa.
@mannodermaus mannodermaus force-pushed the kaizen/build-active-xcframework-only branch from df9d44b to 33be11f Compare August 25, 2024 23:42
@github-actions github-actions bot temporarily deployed to deploygate-distribution August 25, 2024 23:44 Inactive
@mannodermaus mannodermaus marked this pull request as ready for review August 25, 2024 23:46
@takahirom
Copy link
Member

Looks great! But one thing we need to know is that we actually don't use releases yet, and I'm not sure if it works well.

.binaryTarget(name: "KmpModule", path: "../app-ios-shared/build/XCFrameworks/debug/shared.xcframework"),

@mannodermaus
Copy link
Contributor Author

You make a good point there. I have tried to make it work with a conditional target declaration, similar to the content of this PR. But I was unable to access the CONFIGURATION environment variable. Hmm...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants