Updated demo code in NavControllerActivity and added missing documentation for Navigation Components. #50
+347
−265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ersion of navigation components version , the old code did not. Added documentation for setting up bottom bar with navigation components. Linted whole codebase using Kt-Lint
towcar
reviewed
Jul 23, 2022
There was a problem hiding this comment.
Tried using..
PopupMenu p = new PopupMenu(getApplicationContext(), null);
Menu menu = p.getMenu();
bottomBar.setupWithNavController(menu, navController);
it loads, but swapping tabs crashes. Not sure if this was the gist from the pull.
edit:
Fixed by using p.inflate(R.menu.bottom_nav_menu); to assign my bottom nav xml menu.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #48
Changes