Hrg: Action45 add ability to create checkboxes #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lds and checkboxes
hgongloff
changed the title
…ject into hrg_action45
DryCreations
requested changes
Apr 23, 2021
There was a problem hiding this comment.
I'm going to leave similar feedback as I did on #58 & #66
You are not displaying the changes on the pdf canvas, and you are directly modifying the pdf instead. This is not consistent with previous tools. We have been drawing the changes on the canvas, and adding them to an undo stack, and only modifying a pdf whenever we save a docuement.
You may want to look over how DrawRectangle is implemented, the execute method draws the representation of a rectangle on a canvas, and pdfExecute is later used to draw on a pdf when the document is saved.
DryCreations
approved these changes
Apr 27, 2021
bobobo77
approved these changes
May 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
List Any Relevant Actions or Tasks
Actions
Action 45
Tasks
Task 16.3
Description of Changes
I added the ability to create check boxes inside the pdf.
Relevant Artifacts
Before
After
Other Comments
Like actions 43 and 44. I had to create a new folder inside of resources called manipulate_pdf to store both the original and updated pdf. For some reason I could only alter the names of the pdfs if they were not inside the resources folder. Because of this it is not possible to reopen the pdf in our canvas. This could be fixed by having the canvas also use the folder I created for its pdf but I realize this would cause a lot of merge conflicts and might not be an ideal fix.