fix(next-auth): allow users to use the application offline #115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
**Why:** When a user is offline and runs an application, he will always be unauthorized. For my app, I temporarily changed the cache config and now suggesting the same changes. **What changed:** - Update the list of URLs excluded from caching by making it more specific: `/api/auth/` => `/api/auth/callback/`. - Google Auth is tested in _Chrome 119 arm64 for macOS_, _Safari 17.0 for macOS_ ans _Safari for iOS 17.1.1_. - Opening pages offline works fine, tested in the same browsers. - Tested logging out when the user is online and the token is not valid.
🦋 Changeset detectedLatest commit: ed9c2a2 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Hmm, I wonder why the comment specifies |
DuCanhGH
approved these changes
Nov 21, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this changes is necessary
Users currently face authorization issues when accessing next-pwa based application while being offline.
Suggested changes
/api/auth/=>/api/auth/callback/.Tested
Providers:
Browsers:
Actions: